Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 1124173007: Fix typo in --unsafely-treat-insecure-origin-as-secure (Closed)

Created:
5 years, 7 months ago by kinuko
Modified:
5 years, 7 months ago
CC:
Mike West, chromium-reviews, jakearchibald
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix typo in --unsafely-treat-insecure-origin-as-secure 'unsafety' must be 'unsafely', apparently. BUG=441605 Committed: https://crrev.com/722bc522935f02c4c481e10d926e3321a509bab8 Cr-Commit-Position: refs/heads/master@{#330404}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/startup/bad_flags_prompt.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/secure_origin_whitelist.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/secure_origin_whitelist.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/secure_origin_whitelist_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
kinuko
It's a simple typo fix, can some of chrome/ owners take a look?
5 years, 7 months ago (2015-05-18 14:09:12 UTC) #3
Mike West
Ha! Non-OWNERS LGTM, and I'll close my patch doing the same thing: https://codereview.chromium.org/1142823002
5 years, 7 months ago (2015-05-18 15:10:49 UTC) #5
Lei Zhang
lgtm
5 years, 7 months ago (2015-05-18 20:31:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124173007/1
5 years, 7 months ago (2015-05-18 20:32:52 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 20:41:08 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:42:23 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/722bc522935f02c4c481e10d926e3321a509bab8
Cr-Commit-Position: refs/heads/master@{#330404}

Powered by Google App Engine
This is Rietveld 408576698