Issue 1142823002: Rename the secure context whitelist flag from 'unsafety' to 'unsafely'.

Issue 1142823002: Rename the secure context whitelist flag from 'unsafety' to 'unsafely'. (Closed)

Created:
5 years, 7 months ago by Mike West

Modified:
5 years, 7 months ago

Reviewers:
kinuko, jakearchibald

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Rename the secure context whitelist flag from 'unsafety' to 'unsafely'. R=kinuko@chromium.org

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -12 lines)			Patch
M	chrome/browser/chrome_content_browser_client.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/startup/bad_flags_prompt.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/common/secure_origin_whitelist.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/secure_origin_whitelist.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	chrome/common/secure_origin_whitelist_unittest.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 6 (1 generated)

Mike West

Kinuko, how would you feel about renaming this flag from "unsafety" to "unsafely"? The latter ...

5 years, 7 months ago (2015-05-18 15:05:38 UTC) #2

kinuko

On 2015/05/18 15:05:38, Mike West (holiday in DE) wrote: > Kinuko, how would you feel ...

5 years, 7 months ago (2015-05-18 15:08:33 UTC) #3

kinuko

On 2015/05/18 15:08:33, kinuko wrote: > On 2015/05/18 15:05:38, Mike West (holiday in DE) wrote: ...

5 years, 7 months ago (2015-05-18 15:10:16 UTC) #4

Mike West

Ha! Great minds think alike... Closing this in favour of your patch. It's awesome. :) ...

5 years, 7 months ago (2015-05-18 15:11:14 UTC) #5

Mike West

5 years, 7 months ago (2015-05-18 15:11:14 UTC) #6

Ha! Great minds think alike...

Closing this in favour of your patch. It's awesome. :)

-mike