Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1462)

Issue 1124173005: Revert of Linux Aura accessibility is enabled only on GNOME desktops (Closed)

Created:
5 years, 7 months ago by shatch
Modified:
5 years, 7 months ago
CC:
chromium-reviews, je_julie(Not used), plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Linux Aura accessibility is enabled only on GNOME desktops (patchset #15 id:280001 of https://codereview.chromium.org/1028553003/) Reason for revert: All linux perf bots red, failing on various blink_perf tests. Speculatively reverting this CL since several bisects pointed to it. BUG=485590 Original issue's description: > Linux Aura accessibility is enabled only on GNOME desktops > > Linux Aura accessibility is not enabled on desktops different than GNOME2. > GNOME3 has deprecated gconf in favor of gsettings and dconf. > AT-SPI (cross-platform framework that provides communication between AT > and application) bus launcher has a property called org.a11y.Bus.IsEnabled > that could be easily read by dbus call. > > In generall this patch adds an additional check to enable accessibility. > When gconf is available use gnome's accessibility key otherwise > org.a11y.Bus.IsEnabled property. > > BUG=472183, 468989, 468112 > TBR=stevenjb@chromium.org,jochen@chromium.org > > Committed: https://crrev.com/16e2d5a386e3ddd5be818a0d27610b1e9ee9c08e > Cr-Commit-Position: refs/heads/master@{#328651} TBR=dmazzoni@chromium.org,plundblad@chromium.org,l.gombos@samsung.com,jochen@chromium.org,stevenjb@chromium.org,dpranke@chromium.org,k.czech@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=472183, 468989, 468112 Committed: https://crrev.com/c7c15e712cb77a0fe276166996b2bb787490c896 Cr-Commit-Position: refs/heads/master@{#329404}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -183 lines) Patch
M build/linux/system.gyp View 1 chunk +0 lines, -3 lines 0 comments Download
M ui/accessibility/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M ui/accessibility/accessibility.gyp View 1 chunk +1 line, -11 lines 0 comments Download
M ui/accessibility/platform/atk_util_auralinux.h View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/accessibility/platform/atk_util_auralinux.cc View 3 chunks +54 lines, -160 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
shatch
Created Revert of Linux Aura accessibility is enabled only on GNOME desktops
5 years, 7 months ago (2015-05-12 14:44:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124173005/1
5 years, 7 months ago (2015-05-12 14:44:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 14:45:21 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 14:46:13 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7c15e712cb77a0fe276166996b2bb787490c896
Cr-Commit-Position: refs/heads/master@{#329404}

Powered by Google App Engine
This is Rietveld 408576698