Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 1124173004: [iOS] Upstream //ios/chrome/browser/ui/commands changes (Closed)

Created:
5 years, 7 months ago by sdefresne
Modified:
5 years, 7 months ago
Reviewers:
jif
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Upstream //ios/chrome/browser/ui/commands changes ShowSigninCommand is a command to perform a sign in operation. Modernize other commands to use "instancetype", "NS_DESIGNATED_INITIALIZER", "NS_UNAVAILABLE" for the initializers and "@synthetize" for the properties. Remove unused ShowAccountsSettingsCommand. BUG=429756 Committed: https://crrev.com/a92ac8eb225f2c3d9fe0a5fde04850136ee9ee07 Cr-Commit-Position: refs/heads/master@{#329627}

Patch Set 1 #

Patch Set 2 : Fix compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+281 lines, -158 lines) Patch
M ios/chrome/browser/ui/commands/clear_browsing_data_command.h View 1 1 chunk +14 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/commands/clear_browsing_data_command.mm View 1 2 chunks +7 lines, -9 lines 0 comments Download
M ios/chrome/browser/ui/commands/generic_chrome_command.h View 1 1 chunk +7 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/commands/generic_chrome_command.mm View 1 1 chunk +1 line, -7 lines 0 comments Download
M ios/chrome/browser/ui/commands/ios_command_ids.h View 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/ui/commands/open_url_command.h View 1 1 chunk +31 lines, -18 lines 0 comments Download
M ios/chrome/browser/ui/commands/open_url_command.mm View 1 4 chunks +19 lines, -25 lines 0 comments Download
M ios/chrome/browser/ui/commands/set_up_for_testing_command.h View 1 2 chunks +16 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/commands/set_up_for_testing_command.mm View 1 3 chunks +24 lines, -29 lines 0 comments Download
M ios/chrome/browser/ui/commands/set_up_for_testing_command_unittest.mm View 1 3 chunks +11 lines, -0 lines 0 comments Download
D ios/chrome/browser/ui/commands/show_accounts_settings_command.h View 1 chunk +0 lines, -15 lines 0 comments Download
D ios/chrome/browser/ui/commands/show_accounts_settings_command.mm View 1 chunk +0 lines, -15 lines 0 comments Download
M ios/chrome/browser/ui/commands/show_mail_composer_command.h View 1 1 chunk +25 lines, -8 lines 0 comments Download
M ios/chrome/browser/ui/commands/show_mail_composer_command.mm View 1 2 chunks +16 lines, -13 lines 0 comments Download
A ios/chrome/browser/ui/commands/show_signin_command.h View 1 1 chunk +58 lines, -0 lines 0 comments Download
A ios/chrome/browser/ui/commands/show_signin_command.mm View 1 1 chunk +45 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/show_privacy_settings_util.mm View 1 1 chunk +4 lines, -5 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
jif
lgtm
5 years, 7 months ago (2015-05-13 09:15:29 UTC) #3
sdefresne
On 2015/05/13 09:15:29, jif wrote: > lgtm Thank you for the review. Please do not ...
5 years, 7 months ago (2015-05-13 09:47:31 UTC) #4
sdefresne
On 2015/05/13 09:47:31, sdefresne wrote: > On 2015/05/13 09:15:29, jif wrote: > > lgtm > ...
5 years, 7 months ago (2015-05-13 13:19:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1124173004/40001
5 years, 7 months ago (2015-05-13 13:20:21 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 7 months ago (2015-05-13 13:24:23 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 13:25:10 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a92ac8eb225f2c3d9fe0a5fde04850136ee9ee07
Cr-Commit-Position: refs/heads/master@{#329627}

Powered by Google App Engine
This is Rietveld 408576698