Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Unified Diff: ios/chrome/browser/ui/commands/open_url_command.h

Issue 1124173004: [iOS] Upstream //ios/chrome/browser/ui/commands changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix compilation Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/commands/open_url_command.h
diff --git a/ios/chrome/browser/ui/commands/open_url_command.h b/ios/chrome/browser/ui/commands/open_url_command.h
index cf1f69d59212b093933c441e04c0cc05caef516b..878334e035d8dafcc87dfa066998d1154bb13ed7 100644
--- a/ios/chrome/browser/ui/commands/open_url_command.h
+++ b/ios/chrome/browser/ui/commands/open_url_command.h
@@ -19,30 +19,43 @@ class GURL;
// A command to open a new tab.
@interface OpenUrlCommand : GenericChromeCommand
-// Whether or not this URL command comes from a chrome context (e.g., settings),
-// as opposed to a web page context.
-@property(nonatomic, readonly) BOOL fromChrome;
+// Mark inherited initializer as unavailable to prevent calling it by mistake.
+- (instancetype)initWithTag:(NSInteger)tag NS_UNAVAILABLE;
// Initializes a command intended to open a URL as a link from a page.
-// Designated initializer.
-- (id)initWithURL:(const GURL&)url
- referrer:(const web::Referrer&)referrer
- windowName:(NSString*)windowName
- inIncognito:(BOOL)inIncognito
- inBackground:(BOOL)inBackground
- appendTo:(OpenPosition)append;
+- (instancetype)initWithURL:(const GURL&)url
+ referrer:(const web::Referrer&)referrer
+ windowName:(NSString*)windowName
+ inIncognito:(BOOL)inIncognito
+ inBackground:(BOOL)inBackground
+ appendTo:(OpenPosition)append NS_DESIGNATED_INITIALIZER;
// Initializes a command intended to open a URL from browser chrome (e.g.,
// settings). This will always open in a new foreground tab in non-incognito
// mode.
-- (id)initWithURLFromChrome:(const GURL&)url;
-
-- (const GURL&)url;
-- (const web::Referrer&)referrer;
-- (NSString*)windowName;
-- (BOOL)inIncognito;
-- (BOOL)inBackground;
-- (OpenPosition)appendTo;
+- (instancetype)initWithURLFromChrome:(const GURL&)url;
+
+// URL to open.
+@property(nonatomic, readonly) const GURL& url;
+
+// Referrer for the URL.
+@property(nonatomic, readonly) const web::Referrer& referrer;
+
+// Name of the window.
+@property(nonatomic, readonly) NSString* windowName;
+
+// Whether this URL command requests opening in incognito or not.
+@property(nonatomic, readonly) BOOL inIncognito;
+
+// Whether this URL command requests opening in background or not.
+@property(nonatomic, readonly) BOOL inBackground;
+
+// Whether or not this URL command comes from a chrome context (e.g., settings),
+// as opposed to a web page context.
+@property(nonatomic, readonly) BOOL fromChrome;
+
+// Location where the new tab should be opened.
+@property(nonatomic, readonly) OpenPosition appendTo;
@end
« no previous file with comments | « ios/chrome/browser/ui/commands/ios_command_ids.h ('k') | ios/chrome/browser/ui/commands/open_url_command.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698