[Telemetry] Fix page_cycler for pages with client side redirects.

[Telemetry] Fix page_cycler for pages with client side redirects.

Page.disable clears all scripts to evaluate on commit. There is no way
to detect client side redirects because linkedin, for example, performs
its client side redirect after the page has fully loaded.

In order for the page_cyclers to work on pages with client side
redirects, the script to evaluate on commit must execute on the
redirected page.

So to workaround this, we avoid ever calling Page.disable. I don't
expect continuing to listen for notifications here to impact
performance, but if we do see any performance reduction on the bots we
should revert and search for another approach.

This was originally landed as r209505 but had to be rolled out. This
patch simply updates the original patch since the regression was
unrelated and has been fixed.

BUG=253604
NOTRY=true
TEST=tools/perf/run_measurement --browser=canary page_cycler tools/perf/page_sets/top_10_mobile.json --pageset-repeat=2

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=239532

[tonyg, 2013-12-07 01:44:26]

lgtm

Thanks for resurrecting this!

https://codereview.chromium.org/103373003/diff/1/tools/telemetry/telemetry/co...
File tools/telemetry/telemetry/core/backends/chrome/inspector_page.py (left):

https://codereview.chromium.org/103373003/diff/1/tools/telemetry/telemetry/co...
tools/telemetry/telemetry/core/backends/chrome/inspector_page.py:68: except
util.TimeoutException:
Per our offline chat, let's keep this exception so that the timeout message is
correct. Please update the comment below if you can think of a way to make it
better describe why this is here.

[commit-bot: I haz the power, 2013-12-09 19:18:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pdr@chromium.org/103373003/20001

[commit-bot: I haz the power, 2013-12-09 19:39:59]

Change committed as 239532

[achuithb, 2013-12-09 23:06:36]

On 2013/12/09 19:39:59, I haz the power (commit-bot) wrote:
> Change committed as 239532

I'm seeing errors like this:

Traceback (most recent call last):
  File
"/usr/local/google/home/achuith/code/chrome/src/tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py",
line 243, in _HandleNotification
    self._domain_handlers[domain_name][0](res)
  File
"/usr/local/google/home/achuith/code/chrome/src/tools/telemetry/telemetry/core/backends/chrome/inspector_page.py",
line 27, in _OnNotification
    if msg['method'] == 'Page.frameNavigated' and self._navigation_pending:
AttributeError: 'InspectorPage' object has no attribute '_navigation_pending'

[pdr., 2013-12-09 23:08:05]

On 2013/12/09 23:06:36, achuith.bhandarkar wrote:
> On 2013/12/09 19:39:59, I haz the power (commit-bot) wrote:
> > Change committed as 239532
> 
> I'm seeing errors like this:
> 
> Traceback (most recent call last):
>   File
>
"/usr/local/google/home/achuith/code/chrome/src/tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py",
> line 243, in _HandleNotification
>     self._domain_handlers[domain_name][0](res)
>   File
>
"/usr/local/google/home/achuith/code/chrome/src/tools/telemetry/telemetry/core/backends/chrome/inspector_page.py",
> line 27, in _OnNotification
>     if msg['method'] == 'Page.frameNavigated' and self._navigation_pending:
> AttributeError: 'InspectorPage' object has no attribute '_navigation_pending'

[pdr., 2013-12-09 23:08:26]

Can you paste a link to the log?

I'll roll out immediately.

[achuithb, 2013-12-09 23:08:43]

https://codereview.chromium.org/103373003/diff/20001/tools/telemetry/telemetr...
File tools/telemetry/telemetry/core/backends/chrome/inspector_page.py (right):

https://codereview.chromium.org/103373003/diff/20001/tools/telemetry/telemetr...
tools/telemetry/telemetry/core/backends/chrome/inspector_page.py:20:
self._EnablePageNotifications()
I think we need to initialize self._navigation_pending (and maybe others?)
before we do this.

[pdr., 2013-12-09 23:08:53]

A revert of this CL has been created in
https://codereview.chromium.org/110813003/ by pdr@chromium.org.

The reason for reverting is: Causes assertions on the bots.

[pdr., 2013-12-09 23:09:14]

On 2013/12/09 23:08:26, pdr wrote:
> Can you paste a link to the log?
> 
> I'll roll out immediately.

Rolling out with https://codereview.chromium.org/110813003/

[achuithb, 2013-12-09 23:09:20]

On 2013/12/09 23:08:26, pdr wrote:
> Can you paste a link to the log?
> 
> I'll roll out immediately.

this is on my desktop, I'm running telemetry on cros-chrome.