chrome/browser/android/tab_android.h - Issue 1124023004: [DevTools] Fix favicon images on chrome://inspect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/tab_android.h

Issue 1124023004: [DevTools] Fix favicon images on chrome://inspect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/android/tab_android.h

diff --git a/chrome/browser/android/tab_android.h b/chrome/browser/android/tab_android.h

index 241505eae8c2c9d2c37ece908fbd4e285f986756..f297346cb27ae0d38f3342f7c3ff4296d723d187 100644

--- a/chrome/browser/android/tab_android.h

+++ b/chrome/browser/android/tab_android.h

@@ -117,6 +117,8 @@ class TabAndroid : public CoreTabHelperDelegate,

chrome::NavigateParams* params,

content::NavigationController::LoadURLParams* load_url_params);

+ GURL GetFaviconURL();

dgozman 2015/05/08 11:37:03 Perhaps, we should mark this method as being slow

vkuzkokov 2015/05/12 12:16:46 Slow part moved out of TabAndroid.

// CoreTabHelperDelegate ----------------------------------------------------

void SwapTabContents(content::WebContents* old_contents,