Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Side by Side Diff: chrome/browser/android/tab_android.h

Issue 1124023004: [DevTools] Fix favicon images on chrome://inspect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_TAB_ANDROID_H_ 5 #ifndef CHROME_BROWSER_ANDROID_TAB_ANDROID_H_
6 #define CHROME_BROWSER_ANDROID_TAB_ANDROID_H_ 6 #define CHROME_BROWSER_ANDROID_TAB_ANDROID_H_
7 7
8 #include <jni.h> 8 #include <jni.h>
9 9
10 #include "base/android/jni_weak_ref.h" 10 #include "base/android/jni_weak_ref.h"
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 void SetSyncId(int sync_id); 110 void SetSyncId(int sync_id);
111 111
112 void HandlePopupNavigation(chrome::NavigateParams* params); 112 void HandlePopupNavigation(chrome::NavigateParams* params);
113 113
114 bool HasPrerenderedUrl(GURL gurl); 114 bool HasPrerenderedUrl(GURL gurl);
115 115
116 void MakeLoadURLParams( 116 void MakeLoadURLParams(
117 chrome::NavigateParams* params, 117 chrome::NavigateParams* params,
118 content::NavigationController::LoadURLParams* load_url_params); 118 content::NavigationController::LoadURLParams* load_url_params);
119 119
120 GURL GetFaviconURL();
dgozman 2015/05/08 11:37:03 Perhaps, we should mark this method as being slow
vkuzkokov 2015/05/12 12:16:46 Slow part moved out of TabAndroid.
121
120 // CoreTabHelperDelegate ---------------------------------------------------- 122 // CoreTabHelperDelegate ----------------------------------------------------
121 123
122 void SwapTabContents(content::WebContents* old_contents, 124 void SwapTabContents(content::WebContents* old_contents,
123 content::WebContents* new_contents, 125 content::WebContents* new_contents,
124 bool did_start_load, 126 bool did_start_load,
125 bool did_finish_load) override; 127 bool did_finish_load) override;
126 128
127 // Overridden from InstantServiceObserver: 129 // Overridden from InstantServiceObserver:
128 void DefaultSearchProviderChanged( 130 void DefaultSearchProviderChanged(
129 bool google_base_url_domain_changed) override; 131 bool google_base_url_domain_changed) override;
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
235 scoped_ptr<content::WebContents> web_contents_; 237 scoped_ptr<content::WebContents> web_contents_;
236 scoped_ptr<chrome::android::ChromeWebContentsDelegateAndroid> 238 scoped_ptr<chrome::android::ChromeWebContentsDelegateAndroid>
237 web_contents_delegate_; 239 web_contents_delegate_;
238 240
239 scoped_ptr<browser_sync::SyncedTabDelegateAndroid> synced_tab_delegate_; 241 scoped_ptr<browser_sync::SyncedTabDelegateAndroid> synced_tab_delegate_;
240 242
241 DISALLOW_COPY_AND_ASSIGN(TabAndroid); 243 DISALLOW_COPY_AND_ASSIGN(TabAndroid);
242 }; 244 };
243 245
244 #endif // CHROME_BROWSER_ANDROID_TAB_ANDROID_H_ 246 #endif // CHROME_BROWSER_ANDROID_TAB_ANDROID_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698