Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(698)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 1123813002: Move symbol table from per isolate snapshot to vm isolate snapshot, this reduces the per isolate in… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/dart_api_impl_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/dart_api_impl.cc
===================================================================
--- runtime/vm/dart_api_impl.cc (revision 45789)
+++ runtime/vm/dart_api_impl.cc (working copy)
@@ -1425,10 +1425,8 @@
Isolate* isolate = Isolate::Current();
DARTSCOPE(isolate);
TIMERSCOPE(isolate, time_creating_snapshot);
- if (vm_isolate_snapshot_buffer == NULL) {
- RETURN_NULL_ERROR(vm_isolate_snapshot_buffer);
- }
- if (vm_isolate_snapshot_size == NULL) {
+ if (vm_isolate_snapshot_buffer != NULL &&
+ vm_isolate_snapshot_size == NULL) {
RETURN_NULL_ERROR(vm_isolate_snapshot_size);
}
if (isolate_snapshot_buffer == NULL) {
@@ -5076,11 +5074,11 @@
}
CHECK_CALLBACK_STATE(isolate);
- SnapshotReader reader(snapshot->content(),
- snapshot->length(),
- snapshot->kind(),
- isolate,
- zone.GetZone());
+ ASSERT(snapshot->kind() == Snapshot::kScript);
+ ScriptSnapshotReader reader(snapshot->content(),
+ snapshot->length(),
+ isolate,
+ zone.GetZone());
const Object& tmp = Object::Handle(isolate, reader.ReadScriptSnapshot());
if (tmp.IsError()) {
return Api::NewHandle(isolate, tmp.raw());
« no previous file with comments | « runtime/vm/dart.cc ('k') | runtime/vm/dart_api_impl_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698