chrome/browser/profiles/profile.h - Issue 11238034: Added completion notification to Profile's ClearNetworkingHistorySince.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile.h

Issue 11238034: Added completion notification to Profile's ClearNetworkingHistorySince. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed nits, the important question remains. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/browsing_data/browsing_data_remover.cc ('K') | « chrome/browser/profiles/off_the_record_profile_impl.cc ('k') | chrome/browser/profiles/profile_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/profile.h

diff --git a/chrome/browser/profiles/profile.h b/chrome/browser/profiles/profile.h

index 16c34e999dcdce9d4ee2b260ed1062c236a10fd6..5263e902df72c0d5f832a8b79c442064d42f73bf 100644

--- a/chrome/browser/profiles/profile.h

+++ b/chrome/browser/profiles/profile.h

@@ -324,9 +324,10 @@ class Profile : public content::BrowserContext {

// Deletes all network related data since |time|. It deletes transport

// security state since |time| and it also delete HttpServerProperties data.

- // The implementation is free to run this on a background thread, so when this

- // method returns data is not guaranteed to be deleted.

- virtual void ClearNetworkingHistorySince(base::Time time) = 0;

+ // Works asynchronously, however if the |completion| callback is non-null, it

+ // will be fired on the UI thread once the removal process completes.

+ virtual void ClearNetworkingHistorySince(base::Time time,

+ const base::Closure& completion) = 0;

// Returns the home page for this profile.

virtual GURL GetHomePage() = 0;