chrome/browser/profiles/off_the_record_profile_impl.cc - Issue 11238034: Added completion notification to Profile's ClearNetworkingHistorySince.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/off_the_record_profile_impl.cc

Issue 11238034: Added completion notification to Profile's ClearNetworkingHistorySince. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixed nits, the important question remains. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/browsing_data/browsing_data_remover.cc ('K') | « chrome/browser/profiles/off_the_record_profile_impl.h ('k') | chrome/browser/profiles/profile.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/off_the_record_profile_impl.cc

diff --git a/chrome/browser/profiles/off_the_record_profile_impl.cc b/chrome/browser/profiles/off_the_record_profile_impl.cc

index 75d42a62520d1dfa419c5cc24a9833f88e5261a2..b691ae209907aa39c4f74b09cb18656d5f240e47 100644

--- a/chrome/browser/profiles/off_the_record_profile_impl.cc

+++ b/chrome/browser/profiles/off_the_record_profile_impl.cc

@@ -452,8 +452,14 @@ chrome_browser_net::Predictor* OffTheRecordProfileImpl::GetNetworkPredictor() {

return NULL;

}

-void OffTheRecordProfileImpl::ClearNetworkingHistorySince(base::Time time) {

- // No need to do anything here, our transport security state is read-only.

+void OffTheRecordProfileImpl::ClearNetworkingHistorySince(

+ base::Time time,

+ const base::Closure& completion) {

+ // No need to do anything here, our transport security state is read-only, but

+ // fire the callback to be on the safe side.

+ if (!completion.is_null()) {

+ completion.Run();

+ }

}

GURL OffTheRecordProfileImpl::GetHomePage() {