Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 1123733002: [chrome/renderer/media] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed)

Created:
5 years, 7 months ago by anujsharma
Modified:
5 years, 7 months ago
Reviewers:
xhwang, miu
CC:
chromium-reviews, hclam+watch_chromium.org, imcheng+watch_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, feature-media-reviews_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org, Pranay
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in chrome/renderer/media module. MessageLoopProxy is deprecated. This basically does a search and replace: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). BUG=391045 Committed: https://crrev.com/af4ae32730c3c1d522c51973be708af90feff084 Cr-Commit-Position: refs/heads/master@{#328496}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed comments #

Patch Set 3 : Adding changes #

Total comments: 10

Patch Set 4 : Fixing nits #

Total comments: 2

Patch Set 5 : Fixed nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -92 lines) Patch
M chrome/renderer/media/cast_ipc_dispatcher.h View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/renderer/media/cast_ipc_dispatcher.cc View 1 5 chunks +10 lines, -9 lines 0 comments Download
M chrome/renderer/media/cast_ipc_dispatcher_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/media/cast_receiver_session.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/renderer/media/cast_receiver_session.cc View 1 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/renderer/media/cast_receiver_session_delegate.cc View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M chrome/renderer/media/cast_session.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/media/cast_session.cc View 1 2 3 8 chunks +9 lines, -9 lines 0 comments Download
M chrome/renderer/media/cast_session_delegate.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/renderer/media/cast_session_delegate.cc View 1 2 3 11 chunks +17 lines, -16 lines 0 comments Download
M chrome/renderer/media/chrome_webrtc_log_message_delegate.h View 1 2 3 4 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/renderer/media/chrome_webrtc_log_message_delegate.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/media/mock_webrtc_logging_message_filter.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/media/mock_webrtc_logging_message_filter.cc View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/renderer/media/webrtc_logging_message_filter.h View 1 2 2 chunks +5 lines, -8 lines 0 comments Download
M chrome/renderer/media/webrtc_logging_message_filter.cc View 1 2 3 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 17 (3 generated)
anujsharma
PTAL
5 years, 7 months ago (2015-05-04 13:19:00 UTC) #2
miu
https://codereview.chromium.org/1123733002/diff/1/chrome/renderer/media/cast_ipc_dispatcher.h File chrome/renderer/media/cast_ipc_dispatcher.h (right): https://codereview.chromium.org/1123733002/diff/1/chrome/renderer/media/cast_ipc_dispatcher.h#newcode24 chrome/renderer/media/cast_ipc_dispatcher.h:24: const scoped_refptr<base::SingleThreadTaskRunner>& io_message_loop); Should be renamed to io_task_runner or ...
5 years, 7 months ago (2015-05-05 04:05:11 UTC) #4
anujsharma
Thanks miu for your comments! I have made the changes. Could you plesae take a ...
5 years, 7 months ago (2015-05-05 05:10:52 UTC) #5
miu
The same issue occurs in the other files. |io_message_loop| and |io_message_loop_proxy| need to be renamed ...
5 years, 7 months ago (2015-05-05 05:17:28 UTC) #6
anujsharma
On 2015/05/05 05:17:28, miu wrote: > The same issue occurs in the other files. |io_message_loop| ...
5 years, 7 months ago (2015-05-05 05:51:39 UTC) #7
xhwang
Thanks! looking good overall. Just a few nits. https://codereview.chromium.org/1123733002/diff/40001/chrome/renderer/media/cast_ipc_dispatcher.h File chrome/renderer/media/cast_ipc_dispatcher.h (right): https://codereview.chromium.org/1123733002/diff/40001/chrome/renderer/media/cast_ipc_dispatcher.h#newcode64 chrome/renderer/media/cast_ipc_dispatcher.h:64: // ...
5 years, 7 months ago (2015-05-05 16:01:58 UTC) #8
anujsharma
Thanks xhwang for your comments!! I have made the changes. Could you please take a ...
5 years, 7 months ago (2015-05-06 03:42:45 UTC) #9
xhwang
https://codereview.chromium.org/1123733002/diff/60001/chrome/renderer/media/chrome_webrtc_log_message_delegate.h File chrome/renderer/media/chrome_webrtc_log_message_delegate.h (right): https://codereview.chromium.org/1123733002/diff/60001/chrome/renderer/media/chrome_webrtc_log_message_delegate.h#newcode16 chrome/renderer/media/chrome_webrtc_log_message_delegate.h:16: class MessageLoopProxy; SingleThreadTaskRunner?
5 years, 7 months ago (2015-05-06 04:23:18 UTC) #10
anujsharma
Aah my bad :( Sorry missed it. Thanks for pointing it out. PTAL https://codereview.chromium.org/1123733002/diff/60001/chrome/renderer/media/chrome_webrtc_log_message_delegate.h File ...
5 years, 7 months ago (2015-05-06 04:28:49 UTC) #11
xhwang
lgtm Thanks for fixing this!
5 years, 7 months ago (2015-05-06 05:55:37 UTC) #12
anujsharma
On 2015/05/06 05:55:37, xhwang wrote: > lgtm > > Thanks for fixing this! Thanks xhwang ...
5 years, 7 months ago (2015-05-06 05:58:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123733002/80001
5 years, 7 months ago (2015-05-06 05:59:25 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 7 months ago (2015-05-06 06:50:32 UTC) #16
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 06:51:19 UTC) #17
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/af4ae32730c3c1d522c51973be708af90feff084
Cr-Commit-Position: refs/heads/master@{#328496}

Powered by Google App Engine
This is Rietveld 408576698