Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Side by Side Diff: chrome/renderer/media/webrtc_logging_message_filter.cc

Issue 1123733002: [chrome/renderer/media] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed nit Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/renderer/media/webrtc_logging_message_filter.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/media/webrtc_logging_message_filter.h" 5 #include "chrome/renderer/media/webrtc_logging_message_filter.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "base/message_loop/message_loop_proxy.h" 8 #include "base/single_thread_task_runner.h"
9 #include "chrome/common/media/webrtc_logging_messages.h" 9 #include "chrome/common/media/webrtc_logging_messages.h"
10 #include "chrome/renderer/media/chrome_webrtc_log_message_delegate.h" 10 #include "chrome/renderer/media/chrome_webrtc_log_message_delegate.h"
11 #include "ipc/ipc_logging.h" 11 #include "ipc/ipc_logging.h"
12 12
13 WebRtcLoggingMessageFilter::WebRtcLoggingMessageFilter( 13 WebRtcLoggingMessageFilter::WebRtcLoggingMessageFilter(
14 const scoped_refptr<base::MessageLoopProxy>& io_message_loop) 14 const scoped_refptr<base::SingleThreadTaskRunner>& io_task_runner)
15 : io_message_loop_(io_message_loop), 15 : io_task_runner_(io_task_runner),
16 log_message_delegate_(NULL), 16 log_message_delegate_(NULL),
17 sender_(NULL) { 17 sender_(NULL) {
18 // May be null in a browsertest using MockRenderThread. 18 // May be null in a browsertest using MockRenderThread.
19 if (io_message_loop_.get()) { 19 if (io_task_runner_.get()) {
20 io_message_loop_->PostTask( 20 io_task_runner_->PostTask(
21 FROM_HERE, base::Bind( 21 FROM_HERE, base::Bind(
22 &WebRtcLoggingMessageFilter::CreateLoggingHandler, 22 &WebRtcLoggingMessageFilter::CreateLoggingHandler,
23 base::Unretained(this))); 23 base::Unretained(this)));
24 } 24 }
25 } 25 }
26 26
27 WebRtcLoggingMessageFilter::~WebRtcLoggingMessageFilter() { 27 WebRtcLoggingMessageFilter::~WebRtcLoggingMessageFilter() {
28 } 28 }
29 29
30 bool WebRtcLoggingMessageFilter::OnMessageReceived( 30 bool WebRtcLoggingMessageFilter::OnMessageReceived(
31 const IPC::Message& message) { 31 const IPC::Message& message) {
32 DCHECK(io_message_loop_->BelongsToCurrentThread()); 32 DCHECK(io_task_runner_->BelongsToCurrentThread());
33 bool handled = true; 33 bool handled = true;
34 IPC_BEGIN_MESSAGE_MAP(WebRtcLoggingMessageFilter, message) 34 IPC_BEGIN_MESSAGE_MAP(WebRtcLoggingMessageFilter, message)
35 IPC_MESSAGE_HANDLER(WebRtcLoggingMsg_StartLogging, OnStartLogging) 35 IPC_MESSAGE_HANDLER(WebRtcLoggingMsg_StartLogging, OnStartLogging)
36 IPC_MESSAGE_HANDLER(WebRtcLoggingMsg_StopLogging, OnStopLogging) 36 IPC_MESSAGE_HANDLER(WebRtcLoggingMsg_StopLogging, OnStopLogging)
37 IPC_MESSAGE_UNHANDLED(handled = false) 37 IPC_MESSAGE_UNHANDLED(handled = false)
38 IPC_END_MESSAGE_MAP() 38 IPC_END_MESSAGE_MAP()
39 return handled; 39 return handled;
40 } 40 }
41 41
42 void WebRtcLoggingMessageFilter::OnFilterAdded(IPC::Sender* sender) { 42 void WebRtcLoggingMessageFilter::OnFilterAdded(IPC::Sender* sender) {
43 DCHECK(!io_message_loop_.get() || io_message_loop_->BelongsToCurrentThread()); 43 DCHECK(!io_task_runner_.get() || io_task_runner_->BelongsToCurrentThread());
44 sender_ = sender; 44 sender_ = sender;
45 } 45 }
46 46
47 void WebRtcLoggingMessageFilter::OnFilterRemoved() { 47 void WebRtcLoggingMessageFilter::OnFilterRemoved() {
48 DCHECK(!io_message_loop_.get() || io_message_loop_->BelongsToCurrentThread()); 48 DCHECK(!io_task_runner_.get() || io_task_runner_->BelongsToCurrentThread());
49 sender_ = NULL; 49 sender_ = NULL;
50 log_message_delegate_->OnFilterRemoved(); 50 log_message_delegate_->OnFilterRemoved();
51 } 51 }
52 52
53 void WebRtcLoggingMessageFilter::OnChannelClosing() { 53 void WebRtcLoggingMessageFilter::OnChannelClosing() {
54 DCHECK(!io_message_loop_.get() || io_message_loop_->BelongsToCurrentThread()); 54 DCHECK(!io_task_runner_.get() || io_task_runner_->BelongsToCurrentThread());
55 sender_ = NULL; 55 sender_ = NULL;
56 log_message_delegate_->OnFilterRemoved(); 56 log_message_delegate_->OnFilterRemoved();
57 } 57 }
58 58
59 void WebRtcLoggingMessageFilter::AddLogMessages( 59 void WebRtcLoggingMessageFilter::AddLogMessages(
60 const std::vector<WebRtcLoggingMessageData>& messages) { 60 const std::vector<WebRtcLoggingMessageData>& messages) {
61 DCHECK(io_message_loop_->BelongsToCurrentThread()); 61 DCHECK(io_task_runner_->BelongsToCurrentThread());
62 Send(new WebRtcLoggingMsg_AddLogMessages(messages)); 62 Send(new WebRtcLoggingMsg_AddLogMessages(messages));
63 } 63 }
64 64
65 void WebRtcLoggingMessageFilter::LoggingStopped() { 65 void WebRtcLoggingMessageFilter::LoggingStopped() {
66 DCHECK(!io_message_loop_.get() || io_message_loop_->BelongsToCurrentThread()); 66 DCHECK(!io_task_runner_.get() || io_task_runner_->BelongsToCurrentThread());
67 Send(new WebRtcLoggingMsg_LoggingStopped()); 67 Send(new WebRtcLoggingMsg_LoggingStopped());
68 } 68 }
69 69
70 void WebRtcLoggingMessageFilter::CreateLoggingHandler() { 70 void WebRtcLoggingMessageFilter::CreateLoggingHandler() {
71 DCHECK(!io_message_loop_.get() || io_message_loop_->BelongsToCurrentThread()); 71 DCHECK(!io_task_runner_.get() || io_task_runner_->BelongsToCurrentThread());
72 log_message_delegate_ = 72 log_message_delegate_ =
73 new ChromeWebRtcLogMessageDelegate(io_message_loop_, this); 73 new ChromeWebRtcLogMessageDelegate(io_task_runner_, this);
74 } 74 }
75 75
76 void WebRtcLoggingMessageFilter::OnStartLogging() { 76 void WebRtcLoggingMessageFilter::OnStartLogging() {
77 DCHECK(!io_message_loop_.get() || io_message_loop_->BelongsToCurrentThread()); 77 DCHECK(!io_task_runner_.get() || io_task_runner_->BelongsToCurrentThread());
78 log_message_delegate_->OnStartLogging(); 78 log_message_delegate_->OnStartLogging();
79 } 79 }
80 80
81 void WebRtcLoggingMessageFilter::OnStopLogging() { 81 void WebRtcLoggingMessageFilter::OnStopLogging() {
82 DCHECK(!io_message_loop_.get() || io_message_loop_->BelongsToCurrentThread()); 82 DCHECK(!io_task_runner_.get() || io_task_runner_->BelongsToCurrentThread());
83 log_message_delegate_->OnStopLogging(); 83 log_message_delegate_->OnStopLogging();
84 } 84 }
85 85
86 void WebRtcLoggingMessageFilter::Send(IPC::Message* message) { 86 void WebRtcLoggingMessageFilter::Send(IPC::Message* message) {
87 DCHECK(!io_message_loop_.get() || io_message_loop_->BelongsToCurrentThread()); 87 DCHECK(!io_task_runner_.get() || io_task_runner_->BelongsToCurrentThread());
88 if (!sender_) { 88 if (!sender_) {
89 DLOG(ERROR) << "IPC sender not available."; 89 DLOG(ERROR) << "IPC sender not available.";
90 delete message; 90 delete message;
91 } else { 91 } else {
92 sender_->Send(message); 92 sender_->Send(message);
93 } 93 }
94 } 94 }
OLDNEW
« no previous file with comments | « chrome/renderer/media/webrtc_logging_message_filter.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698