Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1457)

Unified Diff: chrome/browser/nacl_host/test/debug_stub_browser_tests.py

Issue 11236025: Test that debug stub works with browser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: rebase Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/nacl_host/test/debug_stub_browser_tests.py
===================================================================
--- chrome/browser/nacl_host/test/debug_stub_browser_tests.py (revision 0)
+++ chrome/browser/nacl_host/test/debug_stub_browser_tests.py (revision 0)
@@ -0,0 +1,23 @@
+# Copyright (c) 2012 The Native Client Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
Mark Seaborn 2012/12/04 21:46:42 Nit: "tests" -> "test" in filename? There is only
halyavin 2012/12/05 10:05:57 I am going to add one or two more simple tests her
+import sys
+
+import gdb_rsp
+
+
+def TestContinue(connection):
+ result = connection.RspRequest('vCont;c')
+ assert result == 'W00' or result == 'X09', result
Mark Seaborn 2012/12/04 21:46:42 FYI, in Python you could write: assert result in
halyavin 2012/12/05 10:05:57 Done.
halyavin 2012/12/05 10:46:44 I investigated further I found that NaCl test modu
+
+
+def Main(args):
+ port = int(args[0])
+ name = args[1]
+ connection = gdb_rsp.GdbRspConnection(('localhost', port))
+ if name == 'continue':
+ TestContinue(connection)
+
Mark Seaborn 2012/12/04 21:46:42 Nit: 2 empty lines between top-level blocks
halyavin 2012/12/05 10:05:57 Done.
+if __name__ == '__main__':
+ Main(sys.argv[1:])

Powered by Google App Engine
This is Rietveld 408576698