chrome/browser/nacl_host/test/debug_stub_browser_tests.py - Issue 11236025: Test that debug stub works with browser.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/nacl_host/test/debug_stub_browser_tests.py

Issue 11236025: Test that debug stub works with browser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: rebase Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/nacl_host/nacl_process_host.cc ('K') | « chrome/browser/nacl_host/nacl_process_host.cc ('k') | chrome/browser/nacl_host/test/gdb_rsp.py » ('j') | chrome/browser/nacl_host/test/gdb_rsp.py » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 # Copyright (c) 2012 The Native Client Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4
	Mark Seaborn 2012/12/04 21:46:42 Nit: "tests" -> "test" in filename? There is only Nit: "tests" -> "test" in filename? There is only one test here. halyavin 2012/12/05 10:05:57 I am going to add one or two more simple tests her Show quoted text On 2012/12/04 21:46:42, Mark Seaborn wrote: > Nit: "tests" -> "test" in filename? There is only one test here. I am going to add one or two more simple tests here.
	5 import sys

	6

	7 import gdb_rsp

	8

	9

	10 def TestContinue(connection):

	11 result = connection.RspRequest('vCont;c')

	12 assert result == 'W00' or result == 'X09', result
	Mark Seaborn 2012/12/04 21:46:42 FYI, in Python you could write: assert result in FYI, in Python you could write: assert result in ('W00', 'X09'), result But why are you accepting one of two results here? Can't you accept only one? If not, please comment why. Also commenting on what W00 and X09 mean would be good. halyavin 2012/12/05 10:05:57 Done. Show quoted text On 2012/12/04 21:46:42, Mark Seaborn wrote: > FYI, in Python you could write: > assert result in ('W00', 'X09'), result > > But why are you accepting one of two results here? Can't you accept only one? > If not, please comment why. Also commenting on what W00 and X09 mean would be > good. Done. halyavin 2012/12/05 10:46:44 I investigated further I found that NaCl test modu I investigated further I found that NaCl test module doesn't exit, it is always killed by browser. So I removed W00 case.
	13

	14

	15 def Main(args):

	16 port = int(args[0])

	17 name = args[1]

	18 connection = gdb_rsp.GdbRspConnection(('localhost', port))

	19 if name == 'continue':

	20 TestContinue(connection)

	21
	Mark Seaborn 2012/12/04 21:46:42 Nit: 2 empty lines between top-level blocks Nit: 2 empty lines between top-level blocks halyavin 2012/12/05 10:05:57 Done. Show quoted text On 2012/12/04 21:46:42, Mark Seaborn wrote: > Nit: 2 empty lines between top-level blocks Done.
	22 if __name__ == '__main__':

	23 Main(sys.argv[1:])

OLD	NEW