Source/core/editing/FrameSelection.h - Issue 1123563003: Improving direction-based selection strategy.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/FrameSelection.h

Issue 1123563003: Improving direction-based selection strategy. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Addressing remaining review feedback. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/FrameSelection.h

diff --git a/Source/core/editing/FrameSelection.h b/Source/core/editing/FrameSelection.h

index d1fefa149bf76ccaeb597c561c2d91590875649c..d2b4fb518618b7c051bb851af19497f45619f52a 100644

--- a/Source/core/editing/FrameSelection.h

+++ b/Source/core/editing/FrameSelection.h

@@ -130,7 +130,7 @@ public:

// This function does not allow the selection to collapse. If the new extent

// is set to the same position as the current base, this function will do

leviw_travelin_and_unemployed 2015/06/03 22:29:47 If the new extent is 'resolved' to the same positi

mfomitchev 2015/06/05 17:38:39 Done.

// nothing.

- void moveRangeSelectionExtent(const VisiblePosition&);

+ void moveRangeSelectionExtent(const IntPoint&);

void moveRangeSelection(const VisiblePosition& base, const VisiblePosition& extent, TextGranularity);

TextGranularity granularity() const { return m_granularity; }