Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(788)

Unified Diff: Source/core/editing/FrameSelection.cpp

Issue 1123563003: Improving direction-based selection strategy. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Addressing remaining review feedback. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/FrameSelection.cpp
diff --git a/Source/core/editing/FrameSelection.cpp b/Source/core/editing/FrameSelection.cpp
index bd543e092efd3523f8d6e061a854a05476e39954..94208d24e2d81fb17b19884501902db8691fb290 100644
--- a/Source/core/editing/FrameSelection.cpp
+++ b/Source/core/editing/FrameSelection.cpp
@@ -1938,12 +1938,12 @@ GranularityStrategy* FrameSelection::granularityStrategy()
return m_granularityStrategy.get();
}
-void FrameSelection::moveRangeSelectionExtent(const VisiblePosition& extentPosition)
+void FrameSelection::moveRangeSelectionExtent(const IntPoint& contentsPoint)
{
- if (isNone() || m_selection.visibleBase() == extentPosition)
+ if (isNone())
return;
- VisibleSelection newSelection = granularityStrategy()->updateExtent(extentPosition, selection());
+ VisibleSelection newSelection = granularityStrategy()->updateExtent(contentsPoint, m_frame);
setSelection(
newSelection,
FrameSelection::CloseTyping | FrameSelection::ClearTypingStyle | FrameSelection::DoNotClearStrategy | UserTriggered,

Powered by Google App Engine
This is Rietveld 408576698