Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1123473004: remove dead code behind BOOL_ONGETINFO (Closed)

Created:
5 years, 7 months ago by reed1
Modified:
5 years, 7 months ago
Reviewers:
reed2
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove dead code behind BOOL_ONGETINFO need this to land in chrome first https://codereview.chromium.org/1125573002 BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/d1290843c364dda7691817f3bb52aadee8391acf

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -82 lines) Patch
M include/codec/SkCodec.h View 2 chunks +0 lines, -19 lines 0 comments Download
M include/core/SkImageGenerator.h View 2 chunks +0 lines, -14 lines 0 comments Download
M src/codec/SkCodec.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkImageGenerator.cpp View 2 chunks +0 lines, -19 lines 0 comments Download
M src/images/SkDecodingImageGenerator.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M src/ports/SkImageGenerator_skia.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M tests/CachedDecodingPixelRefTest.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M tests/DrawBitmapRectTest.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123473004/20001
5 years, 7 months ago (2015-05-05 01:07:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123473004/20001
5 years, 7 months ago (2015-05-05 11:05:32 UTC) #5
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 7 months ago (2015-05-05 11:05:33 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Please ask for an LGTM from a full ...
5 years, 7 months ago (2015-05-05 17:05:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123473004/20001
5 years, 7 months ago (2015-05-05 18:35:50 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 18:36:08 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d1290843c364dda7691817f3bb52aadee8391acf

Powered by Google App Engine
This is Rietveld 408576698