Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1125573002:
onGetInfo is deprecated, just pass info to constructor (Closed)
DescriptiononGetInfo is deprecated, just pass info to constructor
no functionality change, just refactoring.
BUG=
Committed: https://crrev.com/4b06412d951cf97fc0547e49d8582f47e1e36d76
Cr-Commit-Position: refs/heads/master@{#328272}
Patch Set 1 #
Total comments: 4
Patch Set 2 : #Patch Set 3 : #
Messages
Total messages: 27 (11 generated)
reed@chromium.org changed reviewers: + fmalita@chromium.org
The CQ bit was checked by reed@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125573002/1
reed@chromium.org changed reviewers: + jrummell@chromium.org, scherkus@chromium.org
need OWNERS for media/
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
https://codereview.chromium.org/1125573002/diff/1/media/blink/skcanvas_video_... File media/blink/skcanvas_video_renderer.cc (right): https://codereview.chromium.org/1125573002/diff/1/media/blink/skcanvas_video_... media/blink/skcanvas_video_renderer.cc:175: SkImageInfo::MakeN32Premul(frame_->visible_rect().width(), Looks like frame_ is not initialized at this point. Use frame instead? https://codereview.chromium.org/1125573002/diff/1/media/blink/skcanvas_video_... media/blink/skcanvas_video_renderer.cc:177: frame_(frame) { Formatting nit: the comma should go on this line
https://codereview.chromium.org/1125573002/diff/1/media/blink/skcanvas_video_... File media/blink/skcanvas_video_renderer.cc (right): https://codereview.chromium.org/1125573002/diff/1/media/blink/skcanvas_video_... media/blink/skcanvas_video_renderer.cc:175: SkImageInfo::MakeN32Premul(frame_->visible_rect().width(), On 2015/05/03 13:19:01, f(malita) wrote: > Looks like frame_ is not initialized at this point. Use frame instead? Doh! thanks. https://codereview.chromium.org/1125573002/diff/1/media/blink/skcanvas_video_... media/blink/skcanvas_video_renderer.cc:177: frame_(frame) { On 2015/05/03 13:19:01, f(malita) wrote: > Formatting nit: the comma should go on this line Done.
The CQ bit was checked by reed@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125573002/20001
reed@chromium.org changed reviewers: + reed@google.com
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
non-owner lgtm
lgtm
The CQ bit was checked by reed@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125573002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by reed@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jrummell@chromium.org, fmalita@chromium.org Link to the patchset: https://codereview.chromium.org/1125573002/#ps40001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1125573002/40001
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/4b06412d951cf97fc0547e49d8582f47e1e36d76 Cr-Commit-Position: refs/heads/master@{#328272} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
