Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 11234051: Merge 162319 - Fix "Please update your sync passphrase" link on Chrome OS settings. (Closed)

Created:
8 years, 2 months ago by kochi
Modified:
8 years, 2 months ago
Reviewers:
kochi
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Merge 162319 - Fix "Please update your sync passphrase" link on Chrome OS settings. The link was unconditionally associated with browser restart on Chrome OS, which made users think the browser crashed. The action was intended for the case when auth error happened and needs relogin to refresh the authentication credentials when the message is "Sign out then sign in again". For the message "Please update your sync passphrase", don't restart the browser but just show the dialog to prompt sync passphrase. Instead of assigning a fixed handler for the element ($(sync-action-link)), change the action according to whether the message is caused by auth error or anything else. BUG=150740 TEST=repro the issue described in 150740, open chrome://settings and click on "Please update your sync passphrase" message. Review URL: https://codereview.chromium.org/11178004 TBR=kochi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=163471

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M chrome/browser/resources/options/browser_options.js View 2 chunks +12 lines, -9 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
kochi
8 years, 2 months ago (2012-10-23 01:34:39 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698