Fix "Please update your sync passphrase" link on Chrome OS settings.

Fix "Please update your sync passphrase" link on Chrome OS settings.

The link was unconditionally associated with browser restart on Chrome OS,
which made users think the browser crashed.
The action was intended for the case when auth error happened and
needs relogin to refresh the authentication credentials when the message
is "Sign out then sign in again".

For the message "Please update your sync passphrase", don't restart the
browser but just show the dialog to prompt sync passphrase.

Instead of assigning a fixed handler for the element ($(sync-action-link)),
change the action according to whether the message is caused by auth error
or anything else.

BUG=150740
TEST=repro the issue described in 150740, open chrome://settings and click on "Please update your sync passphrase" message.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162319

[kochi, 2012-10-16 10:10:01]

Hi Drew,

Could you review this?

This is getting some user feedbacks, and needs fixing
for trunk and M23.

[Nicolas Zea, 2012-10-17 01:24:16]

sync logic LGTM

[kochi, 2012-10-17 01:39:01]

James or Evan,

Could you take a look for OWNERS review?

[James Hawkins, 2012-10-17 03:13:06]

lgtm

[commit-bot: I haz the power, 2012-10-17 03:25:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kochi@chromium.org/11178004/1

[commit-bot: I haz the power, 2012-10-17 03:40:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kochi@chromium.org/11178004/1

[Evan Stade, 2012-10-17 22:25:39]

http://codereview.chromium.org/11178004/diff/1/chrome/browser/resources/optio...
File chrome/browser/resources/options/browser_options.js (right):

http://codereview.chromium.org/11178004/diff/1/chrome/browser/resources/optio...
chrome/browser/resources/options/browser_options.js:644: if (cr.isChromeOS &&
syncData.hasError) {
you could put this check inside the function instead of repeating
$('sync-action-link').onclick = function(event) { twice.

[kochi, 2012-10-18 02:03:12]

Hi Evan,

Thanks for the review, created another CL.
https://codereview.chromium.org/11194047/