Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: net/quic/quic_network_transaction_unittest.cc

Issue 1123393005: Remove redundant at_read_eof and at_write_eof methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_http_stream_test.cc ('k') | net/quic/quic_stream_factory_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_network_transaction_unittest.cc
diff --git a/net/quic/quic_network_transaction_unittest.cc b/net/quic/quic_network_transaction_unittest.cc
index b78bde6d58ce86b93ec2a5618fe3ae9dd63c77d1..6abf56d1a38de367a262a99ac529e96495f281cc 100644
--- a/net/quic/quic_network_transaction_unittest.cc
+++ b/net/quic/quic_network_transaction_unittest.cc
@@ -823,18 +823,18 @@ TEST_P(QuicNetworkTransactionTest, HungAlternateProtocol) {
// Run the first request.
http_data.StopAfter(arraysize(http_reads) + arraysize(http_writes));
SendRequestAndExpectHttpResponse("hello world");
- ASSERT_TRUE(http_data.at_read_eof());
- ASSERT_TRUE(http_data.at_write_eof());
+ ASSERT_TRUE(http_data.AllReadDataConsumed());
+ ASSERT_TRUE(http_data.AllWriteDataConsumed());
// Now run the second request in which the QUIC socket hangs,
// and verify the the transaction continues over HTTP.
http_data2.StopAfter(arraysize(http_reads) + arraysize(http_writes));
SendRequestAndExpectHttpResponse("hello world");
- ASSERT_TRUE(http_data2.at_read_eof());
- ASSERT_TRUE(http_data2.at_write_eof());
- ASSERT_TRUE(!quic_data.at_read_eof());
- ASSERT_TRUE(!quic_data.at_write_eof());
+ ASSERT_TRUE(http_data2.AllReadDataConsumed());
+ ASSERT_TRUE(http_data2.AllWriteDataConsumed());
+ ASSERT_TRUE(!quic_data.AllReadDataConsumed());
+ ASSERT_TRUE(!quic_data.AllWriteDataConsumed());
}
TEST_P(QuicNetworkTransactionTest, ZeroRTTWithHttpRace) {
@@ -1104,8 +1104,8 @@ TEST_P(QuicNetworkTransactionTest, FailedZeroRttBrokenAlternateProtocol) {
ExpectBrokenAlternateProtocolMapping();
- EXPECT_TRUE(quic_data.at_read_eof());
- EXPECT_TRUE(quic_data.at_write_eof());
+ EXPECT_TRUE(quic_data.AllReadDataConsumed());
+ EXPECT_TRUE(quic_data.AllWriteDataConsumed());
}
TEST_P(QuicNetworkTransactionTest, DISABLED_HangingZeroRttFallback) {
« no previous file with comments | « net/quic/quic_http_stream_test.cc ('k') | net/quic/quic_stream_factory_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698