Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1123383006: [iOS] Cleanup comments in find_in_page.js (Closed)

Created:
5 years, 7 months ago by sdefresne
Modified:
5 years, 7 months ago
Reviewers:
stuartmorgan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[iOS] Cleanup comments in find_in_page.js BUG=None Committed: https://crrev.com/a0933169507826cbbad85333d70312b0e02d3d45 Cr-Commit-Position: refs/heads/master@{#330714}

Patch Set 1 #

Patch Set 2 : Cleanup TODO too #

Patch Set 3 : Add origin #

Total comments: 4

Patch Set 4 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M ios/chrome/browser/find_in_page/resources/find_in_page.js View 1 2 3 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
sdefresne
5 years, 7 months ago (2015-05-18 14:28:48 UTC) #1
sdefresne
PTAL
5 years, 7 months ago (2015-05-18 14:29:17 UTC) #2
stuartmorgan
LGTM with caveats https://codereview.chromium.org/1123383006/diff/40001/ios/chrome/browser/find_in_page/resources/find_in_page.js File ios/chrome/browser/find_in_page/resources/find_in_page.js (right): https://codereview.chromium.org/1123383006/diff/40001/ios/chrome/browser/find_in_page/resources/find_in_page.js#newcode218 ios/chrome/browser/find_in_page/resources/find_in_page.js:218: // TODO(ios): It would be better ...
5 years, 7 months ago (2015-05-19 18:26:47 UTC) #3
sdefresne
Thank you for the review. https://codereview.chromium.org/1123383006/diff/40001/ios/chrome/browser/find_in_page/resources/find_in_page.js File ios/chrome/browser/find_in_page/resources/find_in_page.js (right): https://codereview.chromium.org/1123383006/diff/40001/ios/chrome/browser/find_in_page/resources/find_in_page.js#newcode218 ios/chrome/browser/find_in_page/resources/find_in_page.js:218: // TODO(ios): It would ...
5 years, 7 months ago (2015-05-20 08:05:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123383006/60001
5 years, 7 months ago (2015-05-20 08:05:51 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-20 08:14:09 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 08:14:56 UTC) #9
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a0933169507826cbbad85333d70312b0e02d3d45
Cr-Commit-Position: refs/heads/master@{#330714}

Powered by Google App Engine
This is Rietveld 408576698