Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Unified Diff: ios/chrome/browser/find_in_page/resources/find_in_page.js

Issue 1123383006: [iOS] Cleanup comments in find_in_page.js (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/find_in_page/resources/find_in_page.js
diff --git a/ios/chrome/browser/find_in_page/resources/find_in_page.js b/ios/chrome/browser/find_in_page/resources/find_in_page.js
index c1075824a5ac77237c54e9e345ffd54324d21e5f..c96309192a56031a41a281a3ccb04a7d8ffaa125 100644
--- a/ios/chrome/browser/find_in_page/resources/find_in_page.js
+++ b/ios/chrome/browser/find_in_page/resources/find_in_page.js
@@ -3,13 +3,10 @@
// found in the LICENSE file.
/**
- * This file is lifted from the GoogleMobile find tool.
+ * Based heavily on code from the Google iOS app.
*
* @fileoverview A find in page tool. It scans the DOM for elements with the
* text being search for, and wraps them with a span that highlights them.
- *
- * @author bmcmahan@google.com (Benjamin McMahan)
- *
*/
/**
@@ -867,7 +864,7 @@ __gCrWeb['findInPage'].isVisible = function(elem) {
// only scroll the window, not any scrollable containers in the DOM itself. So
// for now this function returns false if the element is scrolled outside the
// viewable area of its ancestors.
- // TODO (jonwall): handle scrolling within the DOM.
+ // TODO(justincohen): handle scrolling within the DOM.
var pageHeight = __gCrWeb['findInPage'].getBodyHeight();
var pageWidth = __gCrWeb['findInPage'].getBodyWidth();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698