Issue 1123383005: Rely on ExpressionClassifier to match valid arrow function formals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1123383005: Rely on ExpressionClassifier to match valid arrow function formals (Closed)

Created:
5 years, 7 months ago by wingo

Modified:
5 years, 7 months ago

Reviewers:
Dmitry Lomov (no reviews)

CC:
v8-dev, rossberg, arv (Not doing code reviews)

Base URL:
https://chromium.googlesource.com/v8/v8@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Rely on ExpressionClassifier to match valid arrow function formals R=dslomov@chromium.org LOG=N BUG= Committed: https://crrev.com/a9f45ce9acf58450d869ab4895dc297db5487b09 Cr-Commit-Position: refs/heads/master@{#28397}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+9 lines, -69 lines)			Patch
M	src/ast.h	View	2 chunks	+0 lines, -15 lines	0 comments	Download
M	src/parser.cc	View	3 chunks	+5 lines, -31 lines	0 comments	Download
M	src/preparser.h	View	4 chunks	+4 lines, -23 lines	0 comments	Download

Total messages: 6 (1 generated)

wingo

Some cleanups after https://codereview.chromium.org/1138153003/.

5 years, 7 months ago (2015-05-13 10:13:31 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123383005/1

5 years, 7 months ago (2015-05-13 12:44:19 UTC) #4

commit-bot: I haz the power

5 years, 7 months ago (2015-05-13 13:32:49 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a9f45ce9acf58450d869ab4895dc297db5487b09
Cr-Commit-Position: refs/heads/master@{#28397}