Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Unified Diff: src/ast.h

Issue 1123383005: Rely on ExpressionClassifier to match valid arrow function formals (Closed) Base URL: https://chromium.googlesource.com/v8/v8@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/parser.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast.h
diff --git a/src/ast.h b/src/ast.h
index 94ece122c3b933f27638ff034d089f75763d9dd3..6fd5d96f0495c7963145c554012f0623b6c3b658 100644
--- a/src/ast.h
+++ b/src/ast.h
@@ -363,19 +363,6 @@ class Expression : public AstNode {
Bounds bounds() const { return bounds_; }
void set_bounds(Bounds bounds) { bounds_ = bounds; }
- // Whether the expression is parenthesized
- bool is_single_parenthesized() const {
- return IsSingleParenthesizedField::decode(bit_field_);
- }
- bool is_multi_parenthesized() const {
- return IsMultiParenthesizedField::decode(bit_field_);
- }
- void increase_parenthesization_level() {
- bit_field_ = IsMultiParenthesizedField::update(bit_field_,
- is_single_parenthesized());
- bit_field_ = IsSingleParenthesizedField::update(bit_field_, true);
- }
-
// Type feedback information for assignments and properties.
virtual bool IsMonomorphic() {
UNREACHABLE();
@@ -427,8 +414,6 @@ class Expression : public AstNode {
int base_id_;
Bounds bounds_;
class ToBooleanTypesField : public BitField16<byte, 0, 8> {};
- class IsSingleParenthesizedField : public BitField16<bool, 8, 1> {};
- class IsMultiParenthesizedField : public BitField16<bool, 9, 1> {};
uint16_t bit_field_;
// Ends with 16-bit field; deriving classes in turn begin with
// 16-bit fields for optimum packing efficiency.
« no previous file with comments | « no previous file | src/parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698