Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1058)

Issue 1123373002: Revert "Do not correct for zoom for number line-height" (Closed)

Created:
5 years, 7 months ago by rwlbuis
Modified:
5 years, 7 months ago
Reviewers:
chrishtr
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, ed+blinkwatch_opera.com
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert "Do not correct for zoom for number line-height" This reverts commit 162abd30707579099d2c623004d32799f1c0c10b. This causes problems with print preview overlay. BUG=479116 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195013

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -71 lines) Patch
D LayoutTests/fast/css/line-height-number-zoom-get-computed-style.html View 1 chunk +0 lines, -54 lines 0 comments Download
D LayoutTests/fast/css/line-height-number-zoom-get-computed-style-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M Source/core/css/ComputedStyleCSSValueMapping.cpp View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
rwlbuis
PTAL
5 years, 7 months ago (2015-05-06 20:37:45 UTC) #2
chrishtr
Why not just click the revert button on https://codereview.chromium.org/1017173002? Does it not revert cleanly?
5 years, 7 months ago (2015-05-06 22:16:12 UTC) #3
rwlbuis
On 2015/05/06 22:16:12, chrishtr wrote: > Why not just click the revert button on > ...
5 years, 7 months ago (2015-05-06 22:36:49 UTC) #4
chrishtr
lgtm
5 years, 7 months ago (2015-05-06 22:39:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123373002/1
5 years, 7 months ago (2015-05-06 22:40:16 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-07 00:44:46 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195013

Powered by Google App Engine
This is Rietveld 408576698