Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1017173002: Do not correct for zoom for number line-height (Closed)

Created:
5 years, 9 months ago by rwlbuis
Modified:
5 years, 7 months ago
Reviewers:
pdr., eae, chrishtr
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Do not correct for zoom for number line-height When a line-height is specified as a number (for example 1.2) StyleBuilderConverter::convertLineHeight makes a Percent type Length to store in LayoutStyle. When getting the computed style value for line-height, valueForLineHeight uses the zoom-independent FontDescription::specifiedSize. Therefore there is no need in this case to call zoomAdjustedPixelValue. This also fixes the value shown in the computed panel in inspector. BUG=442084 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192124

Patch Set 1 #

Patch Set 2 : Fix unitless line-height #

Patch Set 3 : Add test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
A + LayoutTests/fast/css/line-height-number-zoom-get-computed-style.html View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + LayoutTests/fast/css/line-height-number-zoom-get-computed-style-expected.txt View 1 2 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/core/css/LayoutStyleCSSValueMapping.cpp View 1 2 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
rwlbuis
PTAL
5 years, 9 months ago (2015-03-18 21:25:37 UTC) #2
eae
LGTM
5 years, 9 months ago (2015-03-18 21:32:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017173002/40001
5 years, 9 months ago (2015-03-18 21:32:48 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=192124
5 years, 9 months ago (2015-03-18 23:23:20 UTC) #6
chrishtr
5 years, 7 months ago (2015-05-06 22:39:51 UTC) #8
Message was sent while issue was closed. 
FYI reverted in https://codereview.chromium.org/1123373002/.

Powered by Google App Engine
This is Rietveld 408576698