Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1123313004: Handles AX role for time element(re-land). (Closed)

Created:
5 years, 7 months ago by je_julie(Not used)
Modified:
5 years, 7 months ago
Reviewers:
dmazzoni
CC:
blink-reviews, je_julie, nektarios, dmazzoni, dglazkov+blink, aboxhall
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Handles AX role for time element(re-land). This patch adds InputTimeRole and makes it be used for Input element with time type. In order to handle Time element for AX, the current TimeRole is used. BUG=480861 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195168 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195513

Patch Set 1 #

Patch Set 2 : Update LayoutTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M LayoutTests/accessibility/element-role-mapping-focusable.html View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/accessibility/element-role-mapping-focusable-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXLayoutObject.cpp View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/accessibility/AXNodeObject.cpp View 2 chunks +4 lines, -1 line 0 comments Download
M Source/modules/accessibility/AXObject.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/accessibility/AXObject.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M public/web/WebAXEnums.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dmazzoni
lgtm
5 years, 7 months ago (2015-05-10 06:30:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123313004/20001
5 years, 7 months ago (2015-05-11 00:44:50 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=195168
5 years, 7 months ago (2015-05-11 06:00:08 UTC) #5
Dirk Pranke
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1134103002/ by dpranke@chromium.org. ...
5 years, 7 months ago (2015-05-11 17:14:09 UTC) #6
je_julie(Not used)
On 2015/05/11 17:14:09, Dirk Pranke wrote: > A revert of this CL (patchset #2 id:20001) ...
5 years, 7 months ago (2015-05-19 01:35:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123313004/20001
5 years, 7 months ago (2015-05-19 03:37:20 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 05:03:00 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195513

Powered by Google App Engine
This is Rietveld 408576698