chrome/renderer/chrome_content_renderer_client.cc - Issue 11232068: Extract renderer-side favicon downloading code into separate helper class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 11232068: Extract renderer-side favicon downloading code into separate helper class (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/renderer/chrome_content_renderer_client.cc

diff --git a/chrome/renderer/chrome_content_renderer_client.cc b/chrome/renderer/chrome_content_renderer_client.cc

index 522b9a64bcb84807b1ff16690babf04847bd8179..5f48c3fa7faa87f46deabe882321d7d77139392c 100644

--- a/chrome/renderer/chrome_content_renderer_client.cc

+++ b/chrome/renderer/chrome_content_renderer_client.cc

@@ -43,6 +43,7 @@

#include "chrome/renderer/extensions/miscellaneous_bindings.h"

#include "chrome/renderer/extensions/resource_request_policy.h"

#include "chrome/renderer/external_extension.h"

+#include "chrome/renderer/favicon_helper.h"

#include "chrome/renderer/loadtimes_extension_bindings.h"

#include "chrome/renderer/net/renderer_net_predictor.h"

#include "chrome/renderer/page_click_tracker.h"

@@ -301,7 +302,7 @@ void ChromeContentRendererClient::RenderViewCreated(

extension_dispatcher_.get(), translate);

new PepperHelper(render_view);

+ new FaviconHelper(render_view);

sky 2012/11/15 01:22:17 Add a comment here that FaviconHelper deletes itse

Cait (Slow) 2012/11/15 16:25:26 Done.

// Used only for testing/automation.

if (CommandLine::ForCurrentProcess()->HasSwitch(

switches::kDomAutomationController)) {

« no previous file with comments | « chrome/chrome_renderer.gypi ('k') | chrome/renderer/chrome_render_view_observer.h » ('j') | chrome/renderer/favicon_helper.cc » ('J')