Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: chrome/renderer/chrome_content_renderer_client.cc

Issue 11232068: Extract renderer-side favicon downloading code into separate helper class (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/renderer/chrome_content_renderer_client.h" 5 #include "chrome/renderer/chrome_content_renderer_client.h"
6 6
7 #include <string> 7 #include <string>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 25 matching lines...) Expand all
36 #include "chrome/renderer/chrome_render_process_observer.h" 36 #include "chrome/renderer/chrome_render_process_observer.h"
37 #include "chrome/renderer/chrome_render_view_observer.h" 37 #include "chrome/renderer/chrome_render_view_observer.h"
38 #include "chrome/renderer/content_settings_observer.h" 38 #include "chrome/renderer/content_settings_observer.h"
39 #include "chrome/renderer/extensions/chrome_v8_context.h" 39 #include "chrome/renderer/extensions/chrome_v8_context.h"
40 #include "chrome/renderer/extensions/chrome_v8_extension.h" 40 #include "chrome/renderer/extensions/chrome_v8_extension.h"
41 #include "chrome/renderer/extensions/dispatcher.h" 41 #include "chrome/renderer/extensions/dispatcher.h"
42 #include "chrome/renderer/extensions/extension_helper.h" 42 #include "chrome/renderer/extensions/extension_helper.h"
43 #include "chrome/renderer/extensions/miscellaneous_bindings.h" 43 #include "chrome/renderer/extensions/miscellaneous_bindings.h"
44 #include "chrome/renderer/extensions/resource_request_policy.h" 44 #include "chrome/renderer/extensions/resource_request_policy.h"
45 #include "chrome/renderer/external_extension.h" 45 #include "chrome/renderer/external_extension.h"
46 #include "chrome/renderer/favicon_helper.h"
46 #include "chrome/renderer/loadtimes_extension_bindings.h" 47 #include "chrome/renderer/loadtimes_extension_bindings.h"
47 #include "chrome/renderer/net/renderer_net_predictor.h" 48 #include "chrome/renderer/net/renderer_net_predictor.h"
48 #include "chrome/renderer/page_click_tracker.h" 49 #include "chrome/renderer/page_click_tracker.h"
49 #include "chrome/renderer/page_load_histograms.h" 50 #include "chrome/renderer/page_load_histograms.h"
50 #include "chrome/renderer/pepper/chrome_ppapi_interfaces.h" 51 #include "chrome/renderer/pepper/chrome_ppapi_interfaces.h"
51 #include "chrome/renderer/pepper/pepper_helper.h" 52 #include "chrome/renderer/pepper/pepper_helper.h"
52 #include "chrome/renderer/playback_extension.h" 53 #include "chrome/renderer/playback_extension.h"
53 #include "chrome/renderer/plugins/plugin_placeholder.h" 54 #include "chrome/renderer/plugins/plugin_placeholder.h"
54 #include "chrome/renderer/plugins/plugin_uma.h" 55 #include "chrome/renderer/plugins/plugin_uma.h"
55 #include "chrome/renderer/prerender/prerender_dispatcher.h" 56 #include "chrome/renderer/prerender/prerender_dispatcher.h"
(...skipping 238 matching lines...) Expand 10 before | Expand all | Expand 10 after
294 // notification and can stop the propagation. 295 // notification and can stop the propagation.
295 page_click_tracker->AddListener(password_autofill_manager); 296 page_click_tracker->AddListener(password_autofill_manager);
296 page_click_tracker->AddListener(autofill_agent); 297 page_click_tracker->AddListener(autofill_agent);
297 298
298 TranslateHelper* translate = new TranslateHelper(render_view); 299 TranslateHelper* translate = new TranslateHelper(render_view);
299 new ChromeRenderViewObserver( 300 new ChromeRenderViewObserver(
300 render_view, content_settings, chrome_observer_.get(), 301 render_view, content_settings, chrome_observer_.get(),
301 extension_dispatcher_.get(), translate); 302 extension_dispatcher_.get(), translate);
302 303
303 new PepperHelper(render_view); 304 new PepperHelper(render_view);
304 305 new FaviconHelper(render_view);
sky 2012/11/15 01:22:17 Add a comment here that FaviconHelper deletes itse
Cait (Slow) 2012/11/15 16:25:26 Done.
305 // Used only for testing/automation. 306 // Used only for testing/automation.
306 if (CommandLine::ForCurrentProcess()->HasSwitch( 307 if (CommandLine::ForCurrentProcess()->HasSwitch(
307 switches::kDomAutomationController)) { 308 switches::kDomAutomationController)) {
308 new AutomationRendererHelper(render_view); 309 new AutomationRendererHelper(render_view);
309 } 310 }
310 } 311 }
311 312
312 void ChromeContentRendererClient::SetNumberOfViews(int number_of_views) { 313 void ChromeContentRendererClient::SetNumberOfViews(int number_of_views) {
313 child_process_logging::SetNumberOfViews(number_of_views); 314 child_process_logging::SetNumberOfViews(number_of_views);
314 } 315 }
(...skipping 694 matching lines...) Expand 10 before | Expand all | Expand 10 after
1009 bool ChromeContentRendererClient::IsOtherExtensionWithWebRequestInstalled() { 1010 bool ChromeContentRendererClient::IsOtherExtensionWithWebRequestInstalled() {
1010 return extension_dispatcher_->IsOtherExtensionWithWebRequestInstalled(); 1011 return extension_dispatcher_->IsOtherExtensionWithWebRequestInstalled();
1011 } 1012 }
1012 1013
1013 void ChromeContentRendererClient::RegisterPPAPIInterfaceFactories( 1014 void ChromeContentRendererClient::RegisterPPAPIInterfaceFactories(
1014 webkit::ppapi::PpapiInterfaceFactoryManager* factory_manager) { 1015 webkit::ppapi::PpapiInterfaceFactoryManager* factory_manager) {
1015 factory_manager->RegisterFactory(ChromePPAPIInterfaceFactory); 1016 factory_manager->RegisterFactory(ChromePPAPIInterfaceFactory);
1016 } 1017 }
1017 1018
1018 } // namespace chrome 1019 } // namespace chrome
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698