Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issue 1123163005: Mark internal AccessorInfo properties as "special data properties" (Closed)

Created:
5 years, 7 months ago by Toon Verwaest
Modified:
5 years, 7 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Mark internal AccessorInfo properties as "special data properties" to ensure correct strict-mode handling. BUG= Committed: https://crrev.com/188297160d2b82a4e2a206ebbddfc21dd99a9d8d Cr-Commit-Position: refs/heads/master@{#28369}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -47 lines) Patch
M src/accessors.cc View 1 7 chunks +1 line, -37 lines 0 comments Download
M src/lookup.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/objects.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M src/objects.cc View 1 chunk +11 lines, -4 lines 0 comments Download
M src/objects-inl.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M test/mjsunit/array-length.js View 1 chunk +6 lines, -0 lines 0 comments Download
M test/mjsunit/es6/arguments-iterator.js View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Toon Verwaest
PTAL
5 years, 7 months ago (2015-05-12 13:59:27 UTC) #2
rossberg
LGTM. Apropos, I wish we could rename AccessorInfo vs AccessorPair to something less confusing... https://codereview.chromium.org/1123163005/diff/1/src/objects.h ...
5 years, 7 months ago (2015-05-12 14:09:26 UTC) #3
Toon Verwaest
Addressed comment.
5 years, 7 months ago (2015-05-12 14:19:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123163005/20001
5 years, 7 months ago (2015-05-12 14:19:30 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-12 15:11:23 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/188297160d2b82a4e2a206ebbddfc21dd99a9d8d Cr-Commit-Position: refs/heads/master@{#28369}
5 years, 7 months ago (2015-05-12 15:11:36 UTC) #9
Michael Achenbach
5 years, 7 months ago (2015-05-17 16:50:09 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1142763002/ by machenbach@chromium.org.

The reason for reverting is: [Sheriff] Blocks current roll:
https://codereview.chromium.org/1124403007/

Bisection (https://codereview.chromium.org/1142753002/) points to this CL.
.

Powered by Google App Engine
This is Rietveld 408576698