Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Side by Side Diff: src/objects-inl.h

Issue 1123163005: Mark internal AccessorInfo properties as "special data properties" (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Addressed comment Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects.cc ('k') | test/mjsunit/array-length.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 7018 matching lines...) Expand 10 before | Expand all | Expand 10 after
7029 bool AccessorInfo::all_can_write() { 7029 bool AccessorInfo::all_can_write() {
7030 return BooleanBit::get(flag(), kAllCanWriteBit); 7030 return BooleanBit::get(flag(), kAllCanWriteBit);
7031 } 7031 }
7032 7032
7033 7033
7034 void AccessorInfo::set_all_can_write(bool value) { 7034 void AccessorInfo::set_all_can_write(bool value) {
7035 set_flag(BooleanBit::set(flag(), kAllCanWriteBit, value)); 7035 set_flag(BooleanBit::set(flag(), kAllCanWriteBit, value));
7036 } 7036 }
7037 7037
7038 7038
7039 bool AccessorInfo::is_special_data_property() {
7040 return BooleanBit::get(flag(), kSpecialDataProperty);
7041 }
7042
7043
7044 void AccessorInfo::set_is_special_data_property(bool value) {
7045 set_flag(BooleanBit::set(flag(), kSpecialDataProperty, value));
7046 }
7047
7048
7039 PropertyAttributes AccessorInfo::property_attributes() { 7049 PropertyAttributes AccessorInfo::property_attributes() {
7040 return AttributesField::decode(static_cast<uint32_t>(flag()->value())); 7050 return AttributesField::decode(static_cast<uint32_t>(flag()->value()));
7041 } 7051 }
7042 7052
7043 7053
7044 void AccessorInfo::set_property_attributes(PropertyAttributes attributes) { 7054 void AccessorInfo::set_property_attributes(PropertyAttributes attributes) {
7045 set_flag(Smi::FromInt(AttributesField::update(flag()->value(), attributes))); 7055 set_flag(Smi::FromInt(AttributesField::update(flag()->value(), attributes)));
7046 } 7056 }
7047 7057
7048 7058
(...skipping 549 matching lines...) Expand 10 before | Expand all | Expand 10 after
7598 #undef READ_SHORT_FIELD 7608 #undef READ_SHORT_FIELD
7599 #undef WRITE_SHORT_FIELD 7609 #undef WRITE_SHORT_FIELD
7600 #undef READ_BYTE_FIELD 7610 #undef READ_BYTE_FIELD
7601 #undef WRITE_BYTE_FIELD 7611 #undef WRITE_BYTE_FIELD
7602 #undef NOBARRIER_READ_BYTE_FIELD 7612 #undef NOBARRIER_READ_BYTE_FIELD
7603 #undef NOBARRIER_WRITE_BYTE_FIELD 7613 #undef NOBARRIER_WRITE_BYTE_FIELD
7604 7614
7605 } } // namespace v8::internal 7615 } } // namespace v8::internal
7606 7616
7607 #endif // V8_OBJECTS_INL_H_ 7617 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects.cc ('k') | test/mjsunit/array-length.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698