Issue 1123153005: Fixed DCHECK in StoreIC::CompileHandler().

Issue 1123153005: Fixed DCHECK in StoreIC::CompileHandler(). (Closed)

Created:
5 years, 7 months ago by Igor Sheludko

Modified:
5 years, 7 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Fixed DCHECK in StoreIC::CompileHandler(). BUG=chromium:489597 LOG=N Committed: https://crrev.com/1c673a56c1446b68ab944dced024329ba852e566 Cr-Commit-Position: refs/heads/master@{#28518}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -8 lines)			Patch
M	src/ic/ic.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
A +	test/mjsunit/regress/regress-crbug-489597.js	View	1	1 chunk	+8 lines, -4 lines	0 comments	Download
A +	test/mjsunit/regress/regress-crbug-489597.js-script	View	1	1 chunk	+1 line, -3 lines	0 comments	Download

Total messages: 11 (4 generated)

Toon Verwaest

unit test? why only for internally used properties?

5 years, 7 months ago (2015-05-19 16:57:09 UTC) #4

Igor Sheludko

Unit test added. LookupIterator::LookupInHolder() skips access check for internally used property names, so this DCHECK ...

5 years, 7 months ago (2015-05-19 17:18:09 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123153005/60001

5 years, 7 months ago (2015-05-20 12:47:13 UTC) #9

commit-bot: I haz the power

5 years, 7 months ago (2015-05-20 13:37:04 UTC) #11

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/1c673a56c1446b68ab944dced024329ba852e566
Cr-Commit-Position: refs/heads/master@{#28518}