src/ic/ic.cc - Issue 1123153005: Fixed DCHECK in StoreIC::CompileHandler().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/ic.cc

Issue 1123153005: Fixed DCHECK in StoreIC::CompileHandler(). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Test added Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic/ic.cc

diff --git a/src/ic/ic.cc b/src/ic/ic.cc

index c73398f5a5716a92fcc52658253941e758a3b5bc..ea5c57270f6c4cd0669ddba81b8144cc33b3cbe7 100644

--- a/src/ic/ic.cc

+++ b/src/ic/ic.cc

@@ -1625,7 +1625,8 @@ Handle<Code> StoreIC::CompileHandler(LookupIterator* lookup,

// This is currently guaranteed by checks in StoreIC::Store.

Handle<JSObject> receiver = Handle<JSObject>::cast(lookup->GetReceiver());

Handle<JSObject> holder = lookup->GetHolder<JSObject>();

- DCHECK(!receiver->IsAccessCheckNeeded());

+ DCHECK(!receiver->IsAccessCheckNeeded() ||

+ isolate()->IsInternallyUsedPropertyName(lookup->name()));

switch (lookup->state()) {

case LookupIterator::TRANSITION: {

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-crbug-489597.js » ('j') | no next file with comments »