Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 1123043002: [strong] Fix inlining issue (Closed)

Created:
5 years, 7 months ago by conradw
Modified:
5 years, 7 months ago
Reviewers:
rossberg
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[strong] Fix inlining issue The Hydrogen representation for binops was never changed to care about the language mode. We thought this was ok, but it turns out we need to keep track of it to make sure inlining doesn't mess with the "strongness" of binops. Also added more rigorous inlining testing. BUG=v8:3956 LOG=N Committed: https://crrev.com/97bee8e9644151cf6560c79991b82862066e1eb7 Cr-Commit-Position: refs/heads/master@{#28253}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+393 lines, -118 lines) Patch
M src/arm/lithium-arm.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/lithium-arm64.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/hydrogen.cc View 8 chunks +19 lines, -17 lines 0 comments Download
M src/hydrogen-instructions.h View 29 chunks +78 lines, -46 lines 0 comments Download
M src/hydrogen-instructions.cc View 11 chunks +21 lines, -13 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/lithium-ia32.h View 1 chunk +4 lines, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/lithium-mips.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/lithium-mips64.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/ppc/lithium-codegen-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ppc/lithium-ppc.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/lithium-x64.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/lithium-x87.h View 1 chunk +4 lines, -1 line 0 comments Download
M test/mjsunit/strong/implicit-conversions.js View 2 chunks +0 lines, -32 lines 0 comments Download
A test/mjsunit/strong/implicit-conversions-inlining.js View 1 chunk +235 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
conradw
PTAL
5 years, 7 months ago (2015-05-05 20:01:27 UTC) #3
rossberg
lgtm
5 years, 7 months ago (2015-05-06 10:38:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1123043002/20001
5 years, 7 months ago (2015-05-06 10:38:52 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 7 months ago (2015-05-06 10:40:34 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 10:40:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/97bee8e9644151cf6560c79991b82862066e1eb7
Cr-Commit-Position: refs/heads/master@{#28253}

Powered by Google App Engine
This is Rietveld 408576698