Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Unified Diff: test/mjsunit/strong/implicit-conversions.js

Issue 1123043002: [strong] Fix inlining issue (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/x87/lithium-x87.h ('k') | test/mjsunit/strong/implicit-conversions-inlining.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/strong/implicit-conversions.js
diff --git a/test/mjsunit/strong/implicit-conversions.js b/test/mjsunit/strong/implicit-conversions.js
index 49af153e520f56689a23b908994e49e9e4b2b69a..c13953583fa4e6804d643f69dfa9710a4ed23b09 100644
--- a/test/mjsunit/strong/implicit-conversions.js
+++ b/test/mjsunit/strong/implicit-conversions.js
@@ -199,26 +199,6 @@ let strongStringOrNumberFuncs = [add_strong];
let strongFuncs = strongNumberFuncs.concat(strongStringOrNumberFuncs);
-function inline_sub_strong(x, y) {
- "use strong";
- let v = x - y;
- return v;
-}
-
-function inline_outer(x, y) {
- return inline_sub_strong(x, y);
-}
-
-function inline_sub(x, y) {
- let v = x - y;
- return v;
-}
-
-function inline_outer_strong(x, y) {
- "use strong";
- return inline_sub(x, y);
-}
-
function assertStrongNonThrowBehaviour(expr) {
assertEquals(eval(expr), eval("'use strong';" + expr));
assertDoesNotThrow("'use strong'; " + expr + ";");
@@ -318,15 +298,3 @@ for (let func of strongStringOrNumberFuncs) {
assertThrows(function(){func(2, "foo");}, TypeError);
%DeoptimizeFunction(func);
}
-
-assertThrows(function(){inline_outer(1, {})}, TypeError);
-for (var i = 0; i < 100; i++) {
- inline_outer(1, 2);
-}
-assertThrows(function(){inline_outer(1, {})}, TypeError);
-
-assertDoesNotThrow(function(){inline_outer_strong(1, {})});
-for (var i = 0; i < 100; i++) {
- inline_outer_strong(1, 2);
-}
-assertDoesNotThrow(function(){inline_outer_strong(1, {})});
« no previous file with comments | « src/x87/lithium-x87.h ('k') | test/mjsunit/strong/implicit-conversions-inlining.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698