runtime/bin/file_win.cc - Issue 11230051: Do *not* make file handles inheritable on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/file_win.cc

Issue 11230051: Do *not* make file handles inheritable on Windows. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/file_win.cc

diff --git a/runtime/bin/file_win.cc b/runtime/bin/file_win.cc

index cfce7088583bf5b9e0e3ffc92e9b46a9df14cde0..9076d7a2c411910184158d8c94c68a08e1658417 100644

--- a/runtime/bin/file_win.cc

+++ b/runtime/bin/file_win.cc

@@ -97,9 +97,9 @@ off_t File::Length() {

File* File::Open(const char* name, FileOpenMode mode) {

- int flags = O_RDONLY | O_BINARY;

+ int flags = O_RDONLY | O_BINARY | O_NOINHERIT;

if ((mode & kWrite) != 0) {

- flags = (O_RDWR | O_CREAT | O_BINARY);

+ flags = (O_RDWR | O_CREAT | O_BINARY | O_NOINHERIT);

}

if ((mode & kTruncate) != 0) {

flags = flags | O_TRUNC;

« no previous file with comments | « no previous file | utils/pub/io.dart » ('j') | no next file with comments »