Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Unified Diff: utils/pub/io.dart

Issue 11230051: Do *not* make file handles inheritable on Windows. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/file_win.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: utils/pub/io.dart
diff --git a/utils/pub/io.dart b/utils/pub/io.dart
index 88906792199012ff64450296039abe2a7123197b..517f6f700b1ad57b7e382a19f664e06d2a1dadee 100644
--- a/utils/pub/io.dart
+++ b/utils/pub/io.dart
@@ -655,12 +655,6 @@ Future<bool> _extractTarGzWindows(InputStream stream, String destination) {
tempDir = temp;
return createFileFromStream(stream, join(tempDir, 'data.tar.gz'));
}).chain((_) {
- // TODO(rnystrom): Hack. We get intermittent "file already in use" errors.
- // It looks like the 7zip process is starting up before the file has
- // finished being written. So we'll just sleep for a couple of seconds
- // here. :(
- return sleep(2000);
- }).chain((_) {
// 7zip can't unarchive from gzip -> tar -> destination all in one step
// first we un-gzip it to a tar file.
// Note: Setting the working directory instead of passing in a full file
« no previous file with comments | « runtime/bin/file_win.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698