Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11230007: Resolve redirecting factories. (Closed)

Created:
8 years, 2 months ago by ahe
Modified:
8 years, 1 month ago
CC:
reviews_dartlang.org, aam-me
Visibility:
Public.

Description

Resolve redirecting factories. Committed: https://code.google.com/p/dart/source/detail?r=14558

Patch Set 1 #

Patch Set 2 : Handle unresolved elements. #

Total comments: 2

Patch Set 3 : Rebased #

Total comments: 1

Patch Set 4 : Rebased #

Patch Set 5 : Record element of constructors #

Patch Set 6 : Address review comments #

Total comments: 2

Patch Set 7 : Address review comment #

Patch Set 8 : Rebased #

Patch Set 9 : Fix that I'm stupid #

Patch Set 10 : Update test status #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -8 lines) Patch
M dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 2 3 4 5 6 7 8 5 chunks +32 lines, -6 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/typechecker.dart View 1 2 3 4 5 6 7 1 chunk +1 line, -1 line 0 comments Download
M dart/tests/co19/co19-dart2js.status View 1 2 3 4 5 6 7 8 9 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
ahe
8 years, 2 months ago (2012-10-19 17:32:18 UTC) #1
Lasse Reichstein Nielsen
LGTM
8 years, 2 months ago (2012-10-20 11:50:57 UTC) #2
Johnni Winther
lgtm https://codereview.chromium.org/11230007/diff/3001/dart/lib/compiler/implementation/resolution/members.dart File dart/lib/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/11230007/diff/3001/dart/lib/compiler/implementation/resolution/members.dart#newcode2883 dart/lib/compiler/implementation/resolution/members.dart:2883: resolver.mapping.setType(node, type); I don't like the implicit handling ...
8 years, 2 months ago (2012-10-22 09:47:34 UTC) #3
Johnni Winther
Still LGTM https://codereview.chromium.org/11230007/diff/7001/dart/lib/compiler/implementation/resolution/members.dart File dart/lib/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/11230007/diff/7001/dart/lib/compiler/implementation/resolution/members.dart#newcode2935 dart/lib/compiler/implementation/resolution/members.dart:2935: FunctionElement finishConstructorReference(Element e, Node node) { Strange ...
8 years, 1 month ago (2012-11-05 13:49:33 UTC) #4
ahe
PTAL
8 years, 1 month ago (2012-11-05 14:59:02 UTC) #5
Johnni Winther
lgtm https://codereview.chromium.org/11230007/diff/16002/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart File dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/11230007/diff/16002/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode2956 dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart:2956: /// Finishes resolution of a constructor reference and ...
8 years, 1 month ago (2012-11-05 15:13:53 UTC) #6
ahe
Thank you for the review. https://codereview.chromium.org/11230007/diff/16002/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart File dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart (right): https://codereview.chromium.org/11230007/diff/16002/dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart#newcode2956 dart/sdk/lib/_internal/compiler/implementation/resolution/members.dart:2956: /// Finishes resolution of ...
8 years, 1 month ago (2012-11-06 09:18:45 UTC) #7
ahe
PTAL
8 years, 1 month ago (2012-11-06 09:37:34 UTC) #8
Johnni Winther
8 years, 1 month ago (2012-11-06 09:40:01 UTC) #9 
lgtm

Powered by Google App Engine
This is Rietveld 408576698