Fixed unittest documentation to use new import syntax.

Fixed unittest documentation to use new import syntax.


BUG=http://dartbug.com/6179

[butlermatt, 2012-10-23 16:44:15]

Also added small note about using pub to install package.

[Bob Nystrom, 2012-10-23 18:08:55]

Added some comments. Also, I'm passing this on to Gram to review (and submit)
since unittest is mostly his purview these days. :)

Thanks for the patch!

https://codereview.chromium.org/11229063/diff/1/pkg/unittest/unittest.dart
File pkg/unittest/unittest.dart (right):

https://codereview.chromium.org/11229063/diff/1/pkg/unittest/unittest.dart#ne...
pkg/unittest/unittest.dart:10: * a dependancies for unittest with the following
lines:
"dependancies for" -> "dependency on"

https://codereview.chromium.org/11229063/diff/1/pkg/unittest/unittest.dart#ne...
pkg/unittest/unittest.dart:11: *     name: my_app
You can probably omit this line.

https://codereview.chromium.org/11229063/diff/1/pkg/unittest/unittest.dart#ne...
pkg/unittest/unittest.dart:12: *     dependancies:
"dependancies" -> "dependencies"

https://codereview.chromium.org/11229063/diff/1/pkg/unittest/unittest.dart#ne...
pkg/unittest/unittest.dart:17: * the DartEditor
Add a ".".

https://codereview.chromium.org/11229063/diff/1/pkg/unittest/unittest.dart#ne...
pkg/unittest/unittest.dart:38: *     import 'package:unittest/unitest.dart';
Not related to your change, but we might as well fix this too: should be
"unittest", not "unitest" here and elsewhere. :)

https://codereview.chromium.org/11229063/diff/1/pkg/unittest/unittest.dart#ne...
pkg/unittest/unittest.dart:89: *     import 'dart:html';
How about changing this to import 'dart:isolate' and then use Timer instead of
window.setTimeout here?

[butlermatt, 2012-10-23 19:50:30]

Addressed bob's comments.

https://codereview.chromium.org/11229063/diff/1/pkg/unittest/unittest.dart
File pkg/unittest/unittest.dart (right):

https://codereview.chromium.org/11229063/diff/1/pkg/unittest/unittest.dart#ne...
pkg/unittest/unittest.dart:10: * a dependancies for unittest with the following
lines:
On 2012/10/23 18:08:55, Bob Nystrom wrote:
> "dependancies for" -> "dependency on"

Done.

https://codereview.chromium.org/11229063/diff/1/pkg/unittest/unittest.dart#ne...
pkg/unittest/unittest.dart:11: *     name: my_app
On 2012/10/23 18:08:55, Bob Nystrom wrote:
> You can probably omit this line.

Done.

https://codereview.chromium.org/11229063/diff/1/pkg/unittest/unittest.dart#ne...
pkg/unittest/unittest.dart:12: *     dependancies:
On 2012/10/23 18:08:55, Bob Nystrom wrote:
> "dependancies" -> "dependencies"

Done.

https://codereview.chromium.org/11229063/diff/1/pkg/unittest/unittest.dart#ne...
pkg/unittest/unittest.dart:17: * the DartEditor
On 2012/10/23 18:08:55, Bob Nystrom wrote:
> Add a ".".

Done.

https://codereview.chromium.org/11229063/diff/1/pkg/unittest/unittest.dart#ne...
pkg/unittest/unittest.dart:38: *     import 'package:unittest/unitest.dart';
On 2012/10/23 18:08:55, Bob Nystrom wrote:
> Not related to your change, but we might as well fix this too: should be
> "unittest", not "unitest" here and elsewhere. :)

Done.

https://codereview.chromium.org/11229063/diff/1/pkg/unittest/unittest.dart#ne...
pkg/unittest/unittest.dart:89: *     import 'dart:html';
On 2012/10/23 18:08:55, Bob Nystrom wrote:
> How about changing this to import 'dart:isolate' and then use Timer instead of
> window.setTimeout here?

Done.

[butlermatt, 2012-10-26 16:07:27]

ping

[gram, 2012-10-26 16:33:04]

lgtm

[gram, 2012-10-26 16:33:19]

lgtm
Thanks!

[gram, 2012-10-26 16:35:52]

lgtm
Thanks!

[butlermatt, 2012-10-26 18:44:30]

On 2012/10/26 16:35:52, gram wrote:
> lgtm
> Thanks!

Thanks Gram.
When you have the chance, can you commit this for me, as I don't have rights
myself. :) Thanks.

[gram, 2012-10-26 23:14:45]

Done
On 2012/10/26 18:44:30, butlermatt wrote:
> On 2012/10/26 16:35:52, gram wrote:
> > lgtm
> > Thanks!
> 
> Thanks Gram.
> When you have the chance, can you commit this for me, as I don't have rights
> myself. :) Thanks.