Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1122903002: Merge to XFA: Kill FX_DEFINEHANDLE (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -14 lines) Patch
M core/include/fxcrt/fx_stream.h View 1 chunk +3 lines, -1 line 0 comments Download
M core/include/fxcrt/fx_system.h View 1 chunk +0 lines, -1 line 0 comments Download
M core/include/fxge/fpf.h View 1 chunk +3 lines, -1 line 0 comments Download
M xfa/include/fxjse/fxjse.h View 1 chunk +16 lines, -10 lines 0 comments Download
M xfa/src/fxfa/src/common/xfa_fm2jsapi.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
*not* TBR'd, new changes to review.
5 years, 7 months ago (2015-05-04 22:13:13 UTC) #1
Lei Zhang
lgtm
5 years, 7 months ago (2015-05-04 22:14:20 UTC) #2
Tom Sepez
5 years, 7 months ago (2015-05-04 22:19:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
090d139b66d11b8f9a33b930277aea8becb7f085 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698