Issue 1129433002: Kill FX_DEFINEHANDLE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1129433002: Kill FX_DEFINEHANDLE (Closed)

Created:
5 years, 7 months ago by Tom Sepez

Modified:
5 years, 7 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Kill FX_DEFINEHANDLE I spent at least 2 minutes grep'ing for a class or struct (on the other branch) that was delcared using this. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/2585a6bbd7dca65c4ee3c197937de9b0026a5e98

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -3 lines)			Patch
M	core/include/fxcrt/fx_stream.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	core/include/fxcrt/fx_system.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	core/include/fxge/fpf.h	View	1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Tom Sepez

5 years, 7 months ago (2015-05-04 21:53:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2585a6bbd7dca65c4ee3c197937de9b0026a5e98 (presubmit successful).