Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 1129433002: Kill FX_DEFINEHANDLE (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Kill FX_DEFINEHANDLE I spent at least 2 minutes grep'ing for a class or struct (on the other branch) that was delcared using this. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/2585a6bbd7dca65c4ee3c197937de9b0026a5e98

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M core/include/fxcrt/fx_stream.h View 1 chunk +3 lines, -1 line 0 comments Download
M core/include/fxcrt/fx_system.h View 1 chunk +0 lines, -1 line 0 comments Download
M core/include/fxge/fpf.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Lei, quick review.
5 years, 7 months ago (2015-05-04 21:00:34 UTC) #2
Lei Zhang
lgtm
5 years, 7 months ago (2015-05-04 21:48:02 UTC) #3
Tom Sepez
5 years, 7 months ago (2015-05-04 21:53:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2585a6bbd7dca65c4ee3c197937de9b0026a5e98 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698