Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: tools/build.py

Issue 11228050: Redirect stderr to sys.stdout for build output. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/build.py
===================================================================
--- tools/build.py (revision 13857)
+++ tools/build.py (working copy)
@@ -316,7 +316,9 @@
print k + " = " + v
print ' '.join(args)
- process = subprocess.Popen(args)
+ # We redirect stderr to sys.stdout bacause the buildbot is not
+ # collecting stderr output.
+ process = subprocess.Popen(args, stderr=sys.stdout)
Mads Ager (google) 2012/10/23 08:34:15 Should this just be stderr=STDOUT?
ahe 2012/10/23 08:36:51 That would be stderr=subprocess.STDOUT but that do
Emily Fortuna 2012/10/23 16:46:17 Why does stderr=subprocess.STDOUT not work?
ahe 2012/10/29 12:59:39 I don't know. We tried and it didn't work. However
Emily Fortuna 2012/10/29 16:17:56 alternatively: process = subprocess.Popen(args, st
ahe 2012/11/05 09:58:11 Unfortunately, that would be a severe regression c
process.wait()
if process.returncode != 0:
print "BUILD FAILED"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698