Redirect stderr to sys.stdout for build output.

tools/build.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 #
 
 import optparse
 import os
 import shutil
@@ skipping 298 matching lines @@
                               % os.environ['ANDROID_TOOLCHAIN'])
         toolsOverride = SetTools(arch, toolchainprefix)
         if toolsOverride:
           printToolOverrides = target_os != 'android'
           for k, v in toolsOverride.iteritems():
             args.append(  k + "=" + v)
             if printToolOverrides:
               print k + " = " + v
 
         print ' '.join(args)
-        process = subprocess.Popen(args)
+        # We redirect stderr to sys.stdout bacause the buildbot is not
+        # collecting stderr output.
+        process = subprocess.Popen(args, stderr=sys.stdout)

[Mads Ager (google), 2012/10/23 08:34:15]

Should this just be stderr=STDOUT?

[ahe, 2012/10/23 08:36:51]

That would be stderr=subprocess.STDOUT but that doesn't work.

[Emily Fortuna, 2012/10/23 16:46:17]

Why does stderr=subprocess.STDOUT not work?

[ahe, 2012/10/29 12:59:39]

I don't know. We tried and it didn't work. However, it turned out that this
didn't work either.

[Emily Fortuna, 2012/10/29 16:17:56]

alternatively:
process = subprocess.Popen(args, stderr=subprocess.PIPE, stdout=subprocess.PIPE)
output, stderr = process.communicate()
print output
print stderr, as appropriate.

OR are you trying to get this output on Windows? If so, you probably need
shell=True/

[ahe, 2012/11/05 09:58:11]

Unfortunately, that would be a severe regression compared to the current
behavior. We want to see output incrementally.
 
Not that far yet. We were just trying to redirect stderr to stdout on Linux and
Mac.

         process.wait()
         if process.returncode != 0:
           print "BUILD FAILED"
           return 1
 
   return 0
 
 
 if __name__ == '__main__':
   sys.exit(Main())