lib/compiler/implementation/js_backend/constant_system_javascript.dart - Issue 11227042: isEven, isOdd, isNegative, isMaxValue, isMinValue, isInfinite, isPositive, isSingleValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/js_backend/constant_system_javascript.dart

Issue 11227042: isEven, isOdd, isNegative, isMaxValue, isMinValue, isInfinite, isPositive, isSingleValue. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Rebase. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « lib/compiler/implementation/js_backend/constant_emitter.dart ('k') | lib/compiler/implementation/lib/interceptors.dart » ('j') | lib/core/int.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/compiler/implementation/js_backend/constant_system_javascript.dart

diff --git a/lib/compiler/implementation/js_backend/constant_system_javascript.dart b/lib/compiler/implementation/js_backend/constant_system_javascript.dart

index f4532b531f07098fe039ecd31f3861a05c9bceca..d73ba48272e567957512fb52d7cad98ba01cb105 100644

--- a/lib/compiler/implementation/js_backend/constant_system_javascript.dart

+++ b/lib/compiler/implementation/js_backend/constant_system_javascript.dart

@@ -196,7 +196,7 @@ class JavaScriptConstantSystem implements ConstantSystem {

} else if (constant.isDouble()) {

DoubleConstant doubleResult = constant;

double doubleValue = doubleResult.value;

- if (!doubleValue.isInfinite() && !doubleValue.isNaN() &&

+ if (!doubleValue.isInfinite && !doubleValue.isNaN &&

!constant.isMinusZero()) {

Mads Ager (google) 2012/10/23 16:06:51 This now looks out of place. Maybe follow up with

floitsch 2012/10/23 16:14:19 The constants have a lot of is-methods. I didn't w

int intValue = doubleValue.toInt();

if (intValue == doubleValue && integerFitsIntoDouble(intValue)) {

« no previous file with comments | « lib/compiler/implementation/js_backend/constant_emitter.dart ('k') | lib/compiler/implementation/lib/interceptors.dart » ('j') | lib/core/int.dart » ('J')