isEven, isOdd, isNegative, isMaxValue, isMinValue, isInfinite, isPositive, isSingleValue.

isEven, isOdd, isNegative, isMaxValue, isMinValue, isInfinite, isPositive, isSingleValue.

Committed: https://code.google.com/p/dart/source/detail?r=13974

[Mads Ager (google), 2012-10-23 16:06:51]

LGTM

https://codereview.chromium.org/11227042/diff/2001/lib/compiler/implementatio...
File lib/compiler/implementation/js_backend/constant_system_javascript.dart
(right):

https://codereview.chromium.org/11227042/diff/2001/lib/compiler/implementatio...
lib/compiler/implementation/js_backend/constant_system_javascript.dart:200:
!constant.isMinusZero()) {
This now looks out of place. Maybe follow up with changing this to isMinusZero
in dart2js?

[Florian Schneider, 2012-10-23 16:10:05]

runtime/vm/ part LGTM.

[floitsch, 2012-10-23 16:14:19]

https://codereview.chromium.org/11227042/diff/2001/lib/compiler/implementatio...
File lib/compiler/implementation/js_backend/constant_system_javascript.dart
(right):

https://codereview.chromium.org/11227042/diff/2001/lib/compiler/implementatio...
lib/compiler/implementation/js_backend/constant_system_javascript.dart:200:
!constant.isMinusZero()) {
On 2012/10/23 16:06:51, Mads Ager wrote:
> This now looks out of place. Maybe follow up with changing this to isMinusZero
> in dart2js?

The constants have a lot of is-methods. I didn't want to selectively change
them, so I kept it as is.
But I agree: they need to change too.

[ahe, 2012-10-23 17:38:40]

It would really help me a lot if you could submit a co19 bug when you invalidate
co19 tests and record the bug number on each test.

That is, this saves me time:

Language/10_Expressions/11_Instance_Creation/1_New_A12_t01: Fail, OK # co19
issue 273
LibTest/isolate/SendPort/hashCode_A01_t01: Fail, OK # co19 issue 273
LibTest/core/Map/putIfAbsent_A01_t04: Fail, OK # co19 issue 273
LibTest/core/Map/Map_class_A01_t03: Fail, OK # co19 issue 273
LibTest/core/Set/remove_A01_t03: Fail, OK # co19 issue 273
LibTest/core/Set/addAll_A01_t03: Fail, OK # co19 issue 273
LibTest/core/Set/forEach_A01_t03: Fail, OK # co19 issue 273
LibTest/core/Set/add_A01_t03: Fail, OK # co19 issue 273
LibTest/core/Set/filter_A01_t03: Fail, OK # co19 issue 273
LibTest/core/String/hashCode_A01_t01: Fail, OK # co19 issue 273
LibTest/core/int/hashCode_A01_t01: Fail, OK # co19 issue 273

This costs me time:

# The following tests use isNegative() (function) instead of isNegative
(getter).
LibTest/core/double/NEGATIVE_INFINITY_A01_t01: Fail, OK
LibTest/core/double/INFINITY_A01_t01: Fail, OK
LibTest/core/double/isNegative_A01_t01: Fail, OK
LibTest/core/double/operator_unary_minus_A01_t01: Fail, OK
LibTest/core/double/operator_unary_minus_A01_t03: Fail, OK
LibTest/core/double/isNegative_A01_t02: Fail, OK
LibTest/core/int/isNegative_A01_t01: Fail, OK

And this is not helping, but still causes conflicts when merging:

# The following tests use isInfinite() (function) instead of isInfinite
(getter).
LibTest/core/double/NEGATIVE_INFINITY_A01_t01: Pass, OK
LibTest/core/double/INFINITY_A01_t01: Pass, OK
LibTest/core/double/isInfinite_A01_t03: Pass, OK
LibTest/core/double/isInfinite_A01_t02: Pass, OK
LibTest/core/double/isInfinite_A01_t01: Pass, OK
LibTest/core/int/isInfinite_A01_t01: Pass, OK

[srdjan, 2012-10-23 21:09:41]

https://codereview.chromium.org/11227042/diff/2001/lib/core/int.dart
File lib/core/int.dart (right):

https://codereview.chromium.org/11227042/diff/2001/lib/core/int.dart#newcode50
lib/core/int.dart:50: /** For integers the round method is the identify
function. */
What does 'identify' means in this context?

[floitsch, 2012-10-24 07:49:20]

https://codereview.chromium.org/11227042/diff/2001/lib/core/int.dart
File lib/core/int.dart (right):

https://codereview.chromium.org/11227042/diff/2001/lib/core/int.dart#newcode50
lib/core/int.dart:50: /** For integers the round method is the identify
function. */
On 2012/10/23 21:09:42, srdjan wrote:
> What does 'identify' means in this context?

thanks.
https://codereview.chromium.org/11275002/