Issue 11227036: cc: Change PRESUBMIT to allow COMPILE_ASSERT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11227036: cc: Change PRESUBMIT to allow COMPILE_ASSERT (Closed)

Created:
8 years, 2 months ago by enne (OOO)

Modified:
8 years, 2 months ago

Reviewers:
danakj, jamesr

CC:
chromium-reviews, cc-bugs_chromium.org, danakj

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

cc: Change PRESUBMIT to allow COMPILE_ASSERT The overenthusiastic presubmit tries to prevent ASSERT but also prevents COMPILE_ASSERT, which is valid. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=163396

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	cc/PRESUBMIT.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

woops, thanks :) lgtm