cc/PRESUBMIT.py - Issue 11227036: cc: Change PRESUBMIT to allow COMPILE_ASSERT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/PRESUBMIT.py

Issue 11227036: cc: Change PRESUBMIT to allow COMPILE_ASSERT (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Only touch ASSERT not ASSERT_NOT_REACHED Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/PRESUBMIT.py

diff --git a/cc/PRESUBMIT.py b/cc/PRESUBMIT.py

index 2f2c0f5e28132f3b5131ad61ae467d899817242f..c876419762ee6f29a0460154974d855b69e0ca98 100644

--- a/cc/PRESUBMIT.py

+++ b/cc/PRESUBMIT.py

@@ -22,7 +22,7 @@ def CheckAsserts(input_api, output_api, white_list=CC_SOURCE_FILES, black_list=N

for f in input_api.AffectedSourceFiles(source_file_filter):

contents = input_api.ReadFile(f, 'rb')

# WebKit ASSERT() is not allowed.

- if re.search(r"ASSERT\(", contents):

+ if re.search(r"\bASSERT\(", contents):

assert_files.append(f.LocalPath())

# WebKit ASSERT_NOT_REACHED() is not allowed.

if re.search(r"ASSERT_NOT_REACHED\(", contents):

« no previous file with comments | « no previous file | no next file » | no next file with comments »