Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11227033: Move a bunch of code in content\common (as well as a few left in renderer) to the content namespace. (Closed)

Created:
8 years, 2 months ago by jam
Modified:
8 years, 2 months ago
Reviewers:
scottmg
CC:
chromium-reviews, michaeln, cbentzel+watch_chromium.org, tzik+watch_chromium.org, jam, apatrick_chromium, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, kinuko+watch, erikwright+watch_chromium.org
Visibility:
Public.

Description

Move a bunch of code in content\common (as well as a few left in renderer) to the content namespace. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=163359

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : fix cros #

Patch Set 5 : fix cros #

Unified diffs Side-by-side diffs Delta from patch set Stats (+558 lines, -210 lines) Patch
M base/threading/thread_restrictions.h View 4 chunks +2 lines, -2 lines 0 comments Download
M content/app/content_main_runner.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_main_runner.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/in_process_webkit/browser_webkitplatformsupport_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/in_process_webkit/browser_webkitplatformsupport_impl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/renderer_host/image_transport_factory.cc View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/image_transport_factory_android.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/common/appcache/appcache_backend_proxy.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/appcache/appcache_backend_proxy.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/appcache/appcache_dispatcher.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/appcache/appcache_dispatcher.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/child_process.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/common/child_process.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/child_thread.h View 6 chunks +13 lines, -12 lines 0 comments Download
M content/common/child_thread.cc View 4 chunks +6 lines, -4 lines 0 comments Download
M content/common/child_trace_message_filter.h View 2 chunks +3 lines, -1 line 0 comments Download
M content/common/child_trace_message_filter.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/database_util.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/common/database_util.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/fileapi/file_system_dispatcher.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/fileapi/file_system_dispatcher.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/fileapi/webblobregistry_impl.h View 2 chunks +5 lines, -2 lines 0 comments Download
M content/common/fileapi/webblobregistry_impl.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/fileapi/webfilesystem_callback_dispatcher.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/fileapi/webfilesystem_callback_dispatcher.cc View 1 2 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/fileapi/webfilesystem_impl.h View 1 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/fileapi/webfilesystem_impl.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/fileapi/webfilewriter_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/fileapi/webfilewriter_impl.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.h View 2 chunks +6 lines, -2 lines 0 comments Download
M content/common/gpu/client/command_buffer_proxy_impl.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M content/common/gpu/client/gpu_channel_host.h View 6 chunks +13 lines, -13 lines 0 comments Download
M content/common/gpu/client/gpu_channel_host.cc View 5 chunks +6 lines, -4 lines 0 comments Download
M content/common/gpu/client/gpu_video_decode_accelerator_host.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/common/gpu/client/gpu_video_decode_accelerator_host.cc View 3 chunks +7 lines, -4 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h View 5 chunks +9 lines, -7 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 6 chunks +8 lines, -5 lines 0 comments Download
M content/common/gpu/gpu_channel.h View 6 chunks +9 lines, -5 lines 0 comments Download
M content/common/gpu/gpu_channel.cc View 5 chunks +6 lines, -3 lines 0 comments Download
M content/common/gpu/gpu_channel_manager.h View 2 chunks +5 lines, -1 line 0 comments Download
M content/common/gpu/gpu_channel_manager.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.h View 3 chunks +9 lines, -5 lines 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.cc View 4 chunks +5 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_memory_allocation.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/gpu/gpu_memory_manager.h View 2 chunks +9 lines, -3 lines 0 comments Download
M content/common/gpu/gpu_memory_manager.cc View 3 chunks +4 lines, -1 line 0 comments Download
M content/common/gpu/gpu_memory_manager_unittest.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/gpu/gpu_memory_tracking.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/gpu/gpu_messages.h View 2 chunks +2 lines, -2 lines 0 comments Download
M content/common/gpu/gpu_watchdog.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/gpu/image_transport_surface.h View 3 chunks +6 lines, -3 lines 0 comments Download
M content/common/gpu/image_transport_surface.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/gpu/image_transport_surface_android.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/gpu/image_transport_surface_linux.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/gpu/image_transport_surface_mac.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/common/gpu/image_transport_surface_win.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/gpu/stream_texture_manager_android.h View 2 chunks +1 line, -1 line 0 comments Download
M content/common/gpu/sync_point_manager.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/gpu/sync_point_manager.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/gpu/texture_image_transport_surface.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/common/gpu/texture_image_transport_surface.cc View 6 chunks +9 lines, -5 lines 0 comments Download
M content/common/indexed_db/indexed_db_dispatcher.h View 8 chunks +16 lines, -19 lines 0 comments Download
M content/common/indexed_db/indexed_db_dispatcher.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M content/common/indexed_db/indexed_db_dispatcher_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/common/indexed_db/indexed_db_message_filter.h View 2 chunks +5 lines, -2 lines 0 comments Download
M content/common/indexed_db/indexed_db_message_filter.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/indexed_db/proxy_webidbcursor_impl.h View 4 chunks +10 lines, -6 lines 0 comments Download
M content/common/indexed_db/proxy_webidbcursor_impl.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/common/indexed_db/proxy_webidbdatabase_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/indexed_db/proxy_webidbdatabase_impl.cc View 3 chunks +5 lines, -1 line 0 comments Download
M content/common/indexed_db/proxy_webidbfactory_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/indexed_db/proxy_webidbfactory_impl.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/indexed_db/proxy_webidbindex_impl.h View 2 chunks +5 lines, -0 lines 0 comments Download
M content/common/indexed_db/proxy_webidbindex_impl.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M content/common/indexed_db/proxy_webidbobjectstore_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/indexed_db/proxy_webidbobjectstore_impl.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M content/common/indexed_db/proxy_webidbtransaction_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/indexed_db/proxy_webidbtransaction_impl.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/net/url_request_user_data.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/net/url_request_user_data.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/quota_dispatcher.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/quota_dispatcher.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/common/socket_stream_dispatcher.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/socket_stream_dispatcher.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/webkitplatformsupport_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/common/webmessageportchannel_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/common/webmessageportchannel_impl.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/gpu/gpu_child_thread.h View 4 chunks +6 lines, -4 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 7 chunks +9 lines, -6 lines 0 comments Download
M content/gpu/gpu_main.cc View 7 chunks +9 lines, -7 lines 0 comments Download
M content/gpu/gpu_process.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/gpu/gpu_process.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/gpu/gpu_watchdog_thread.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/gpu/gpu_watchdog_thread.cc View 3 chunks +4 lines, -1 line 0 comments Download
M content/public/test/render_view_fake_resources_test.h View 2 chunks +1 line, -1 line 0 comments Download
M content/public/test/render_view_test.h View 2 chunks +2 lines, -4 lines 0 comments Download
M content/renderer/gpu/stream_texture_host_android.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/renderer_gpu_video_decoder_factories.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/renderer/media/stream_texture_factory_impl_android.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/pepper/pepper_parent_context_provider.h View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/pepper/pepper_platform_context_3d_impl.h View 1 chunk +2 lines, -6 lines 0 comments Download
M content/renderer/plugin_channel_host.h View 2 chunks +5 lines, -1 line 0 comments Download
M content/renderer/plugin_channel_host.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/render_process.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/render_process_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/render_process_impl.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.h View 2 chunks +1 line, -2 lines 0 comments Download
M content/renderer/renderer_main_platform_delegate.h View 3 chunks +6 lines, -2 lines 0 comments Download
M content/renderer/renderer_main_platform_delegate_android.cc View 2 chunks +5 lines, -1 line 0 comments Download
M content/renderer/renderer_main_platform_delegate_linux.cc View 3 chunks +6 lines, -2 lines 0 comments Download
M content/renderer/renderer_main_platform_delegate_mac.mm View 3 chunks +6 lines, -2 lines 0 comments Download
M content/renderer/renderer_main_platform_delegate_win.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M content/renderer/renderer_webkitplatformsupport_impl.h View 2 chunks +2 lines, -3 lines 0 comments Download
M content/renderer/webplugin_delegate_proxy.h View 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/websharedworker_proxy.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/websharedworker_proxy.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/websharedworkerrepository_impl.h View 2 chunks +4 lines, -0 lines 0 comments Download
M content/renderer/websharedworkerrepository_impl.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M content/test/mock_render_process.h View 2 chunks +3 lines, -0 lines 0 comments Download
M content/test/mock_render_process.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M content/worker/worker_thread.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/worker/worker_thread.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/worker/worker_webkitplatformsupport_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M gpu/ipc/command_buffer_proxy.h View 2 chunks +5 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_command_buffer_proxy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ppapi/proxy/ppapi_command_buffer_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 2 months ago (2012-10-22 18:08:25 UTC) #1
scottmg
8 years, 2 months ago (2012-10-22 18:16:50 UTC) #2 
lgtm

https://codereview.chromium.org/11227033/diff/1/content/common/fileapi/webfil...
File content/common/fileapi/webfilesystem_impl.h (right):

https://codereview.chromium.org/11227033/diff/1/content/common/fileapi/webfil...
content/common/fileapi/webfilesystem_impl.h:68: }  // namespace contentf
contentf

Powered by Google App Engine
This is Rietveld 408576698